Date: Thu, 5 Nov 2015 11:13:21 -0700 From: Warner Losh <imp@bsdimp.com> To: Adrian Chadd <adrian@freebsd.org> Cc: NGie Cooper <yaneurabeya@gmail.com>, "O'Connor, Daniel" <darius@dons.net.au>, "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: COMPILER_TYPE and installworld Message-ID: <CANCZdfpO05DyGmT2Fdhmvx719P_m2VmTSRmsG2JYnMyruS5ahQ@mail.gmail.com> In-Reply-To: <CAJ-VmomJVmAHLzN8XWj3QUd0Gp4_7i-Yr3Krqb=idA-eJxmmMg@mail.gmail.com> References: <CAJ-VmomkWx=GMFGMexanH892iFoGQUFU8jo=qTvYnqp3bQoTDA@mail.gmail.com> <CAJ-VmokbRp8w9_3CrEcHVn%2Bnrhfs3TAF01JrNPptoVzTB30LTA@mail.gmail.com> <CAJ-VmokUOMFMF2LE89Uc9unmmBwGusMzU_r%2BF=GKMe0c1g=DMA@mail.gmail.com> <CAJ-Vmoni7rBBP_ePU2-W11FTOunRCWLSeWYe1i9FxyoUUdd10g@mail.gmail.com> <26BD9533-2C1E-4198-9AC2-BDD77A08337D@dons.net.au> <35BA9AA9-6DFA-4CFC-8AA8-25B1D9EDD494@gmail.com> <CAJ-VmomJVmAHLzN8XWj3QUd0Gp4_7i-Yr3Krqb=idA-eJxmmMg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 5, 2015 at 9:02 AM, Adrian Chadd <adrian@freebsd.org> wrote: > On 4 November 2015 at 23:46, NGie Cooper <yaneurabeya@gmail.com> wrote: > > > >> On Nov 4, 2015, at 23:08, O'Connor, Daniel <darius@dons.net.au> wrote: > >> > >> > >>> On 5 Nov 2015, at 16:31, Adrian Chadd <adrian@freebsd.org> wrote: > >>> So! In the short term, is there any way that during > >>> installworld/installkernel we can also set CC, etc appropriately? > >>> Otherwise we're either using the wrong compiler logic/version > >>> (installkernel) or we're just plain not going to work (installworld.) > >> > >> Why does installworld/kernel care what the compiler type is? > >> > >> Or is it just something incidental which gets pulled in that complains > because it can't work it out? If so perhaps the easiest way would be to a= dd > a flag which turns off compiler detection and set it for install* > >> > >> If install* _do_ need to know the compiler type then, bleh.. > > > > It shouldn=E2=80=99t care. bsd.compiler.mk just has the intelligence of= a stump > and Makefile.inc1 doesn=E2=80=99t tell bsd.compiler.mk to do otherwise in= the > distribution/install phases. > > > > If it were up to me, CC would be false when make install* is run from > Makefile.inc1. > > I don't mind what people do, I'd just really appreciate some help > fixing this up. I think we're pretty close to being able to transition > mips over to using 100% external toolchain only, and this is the > starting point. > > So, what can we do? Pretty please? :) > Sadly, CC=3Dtrue (or CC=3Dfalse) doesn't solve the problem. The defaults on the system depend, stupidly[*], on the compiler you are using and it's capabilities. This means you won't install all the bits that need C++11 to build, for example. I'm joining this discussion late. What circumstances do we get CC wrong in install*? For ages, that's been working properly. What changed? I suspect 'nothing' and this is nothing more than a pilot error, but it's possible it's a real bug. Most likely it's the specific flavor of external toolchain that Bapt added isn't quite setting variables the way it should. Warner [*] I've railed against this in the past to no good effect, mind you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpO05DyGmT2Fdhmvx719P_m2VmTSRmsG2JYnMyruS5ahQ>