From owner-svn-src-head@freebsd.org Tue Jul 12 21:56:54 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25452B934F2; Tue, 12 Jul 2016 21:56:54 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AC52C1F79; Tue, 12 Jul 2016 21:56:53 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u6CLuqgH028834; Tue, 12 Jul 2016 21:56:52 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u6CLuqp2028833; Tue, 12 Jul 2016 21:56:52 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201607122156.u6CLuqp2028833@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: "Conrad E. Meyer" Date: Tue, 12 Jul 2016 21:56:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302681 - head/sys/dev/ioat X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2016 21:56:54 -0000 Author: cem Date: Tue Jul 12 21:56:52 2016 New Revision: 302681 URL: https://svnweb.freebsd.org/changeset/base/302681 Log: ioat(4): Remove force_hw_error sysctl; it does not work reliably Modified: head/sys/dev/ioat/ioat.c Modified: head/sys/dev/ioat/ioat.c ============================================================================== --- head/sys/dev/ioat/ioat.c Tue Jul 12 21:56:49 2016 (r302680) +++ head/sys/dev/ioat/ioat.c Tue Jul 12 21:56:52 2016 (r302681) @@ -1975,38 +1975,6 @@ out: } static int -sysctl_handle_error(SYSCTL_HANDLER_ARGS) -{ - struct ioat_descriptor *desc; - struct ioat_softc *ioat; - int error, arg; - - ioat = arg1; - - arg = 0; - error = SYSCTL_OUT(req, &arg, sizeof(arg)); - if (error != 0 || req->newptr == NULL) - return (error); - - error = SYSCTL_IN(req, &arg, sizeof(arg)); - if (error != 0) - return (error); - - if (arg != 0) { - ioat_acquire(&ioat->dmaengine); - desc = ioat_op_generic(ioat, IOAT_OP_COPY, 1, - 0xffff000000000000ull, 0xffff000000000000ull, NULL, NULL, - 0); - if (desc == NULL) - error = ENOMEM; - else - ioat_submit_single(ioat); - ioat_release(&ioat->dmaengine); - } - return (error); -} - -static int sysctl_handle_reset(SYSCTL_HANDLER_ARGS) { struct ioat_softc *ioat; @@ -2107,9 +2075,6 @@ ioat_setup_sysctl(device_t device) SYSCTL_ADD_PROC(ctx, hammer, OID_AUTO, "force_hw_reset", CTLTYPE_INT | CTLFLAG_RW, ioat, 0, sysctl_handle_reset, "I", "Set to non-zero to reset the hardware"); - SYSCTL_ADD_PROC(ctx, hammer, OID_AUTO, "force_hw_error", - CTLTYPE_INT | CTLFLAG_RW, ioat, 0, sysctl_handle_error, "I", - "Set to non-zero to inject a recoverable hardware error"); tmp = SYSCTL_ADD_NODE(ctx, par, OID_AUTO, "stats", CTLFLAG_RD, NULL, "IOAT channel statistics");