From owner-dev-commits-src-all@freebsd.org Thu May 20 01:39:42 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 92679630A4B for ; Thu, 20 May 2021 01:39:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlsqL3Xlfz4fkb for ; Thu, 20 May 2021 01:39:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x829.google.com with SMTP id i19so5178805qtw.9 for ; Wed, 19 May 2021 18:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LRdrpbLhHwedpUus4wzNNszy5c4QqGGBw1NsfRXXkkg=; b=R5MzbBSA7vyxVC5PvmqSuveEDNJsh/UFHkK6bqnGd9ochXSjB/rsskVKBjVYmt0E0h XL8GNbIsqf7nbfA1CuHGYpFftgWU+wakXrW9laVAMbCg8Mnohr7/DAqD8QMmLerC7hcz Z9aORPwpesA4sdsOZaNHgGpRT2Jh/JLYZsJA83Wgpa+iRaiRsB3hivI0sLbToayMU8c3 NYiPha3jdTAJCBTW6w/zG8VPgVSJII4jnGWg6sj/daeVo9hoZXAfaOdk1bYMLnfeGUgp /5epDf3/dYdTUIgRfPNK0KCRi5aO4kmG95W1gIvkFDDxPOxig6j1XeNNvJKAVC2yRt7s 9ndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LRdrpbLhHwedpUus4wzNNszy5c4QqGGBw1NsfRXXkkg=; b=LBfRYl+T9bS1cNRJFtguEt2yXBldeSU8bXUtmLmVH1P63F48mRBI8mXlMWRsBFyUK9 6ay8Pcjt0mwVhqaMs9f6mdu6yiPSa9cI4mM6AA+8xzARKwEGIFxNG+H9o8EFL9z28ajD wNxqPqwTCuIU9aq/oF3Ya0a0tIOdBOTvHDthKePnj4Fd2PV4j1gebt19kRKMdMFeZbqR hCFTA2rkqXCt8hny1R4fGrEnYCenv/azD4kxGcVyRHEiBpIac2/dhf0IK0y73lI4M/Sl GY4ef/GHjE6HNdtW/xt1x61h/KHgIdV8iaErqVtfHHithYW2cwpLqDAkfblh6zeUkawv X9bQ== X-Gm-Message-State: AOAM533uyMbcn+Ng8C0zbS6w5TnvjXHP+tO9XpnICwbHZLIPxAvQ94Yj ARgQSFugLCRzMwPTBJjTV8dHoelkJcRAXUM9yH4u4Q== X-Google-Smtp-Source: ABdhPJy7o2dF7ltEHI+4H9ZlwRjuAcMwQ4M3+sXRn6QmfGSGUlxnf8OYNchjnzmtfWop6Tsj/B8lPQkPfPEB3CdyrBY= X-Received: by 2002:a05:622a:588:: with SMTP id c8mr2618268qtb.49.1621474781496; Wed, 19 May 2021 18:39:41 -0700 (PDT) MIME-Version: 1.0 References: <202105191744.14JHi6fA008046@gitrepo.freebsd.org> <9BE6FB36-5958-4220-9C95-86DED767F6ED@freebsd.org> In-Reply-To: <9BE6FB36-5958-4220-9C95-86DED767F6ED@freebsd.org> From: Warner Losh Date: Wed, 19 May 2021 19:39:30 -0600 Message-ID: Subject: Re: git: 086feed850c3 - main - md5: Create md5sum, etc compatible programs To: Jessica Clarke Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FlsqL3Xlfz4fkb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 01:39:42 -0000 On Wed, May 19, 2021, 12:32 PM Jessica Clarke wrote: > On 19 May 2021, at 18:44, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D086feed850c31c278f25c958b97992d= 024139896 > > > > commit 086feed850c31c278f25c958b97992d024139896 > > Author: Warner Losh > > AuthorDate: 2021-05-19 17:26:20 +0000 > > Commit: Warner Losh > > CommitDate: 2021-05-19 17:41:53 +0000 > > > > md5: Create md5sum, etc compatible programs > > > > On Linux, there's a similar set of programs to ours, but that end in > the > > letters 'sum'. These act basically like FreeBSD versions run with th= e > -r > > option. Add code so that when the program ends in 'sum' you get the > > linux -r behavior. This is enough to make most things that use sha*s= um > > work correctly (the -c / --check options, as well as the long args a= re > > not implemented). When running with the -sum programs, ignore -t > instead > > of running internal speed tests and make -c an error. > > > > Reviewed by: sef, and kp and allanjude (earlier version) > > Relnotes: yes > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D30309 > > --- > > diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c > > index 96dfcede9711..4381ef124c7b 100644 > > --- a/sbin/md5/md5.c > > +++ b/sbin/md5/md5.c > > @@ -177,13 +177,32 @@ main(int argc, char *argv[]) > > char buf[HEX_DIGEST_LENGTH]; > > size_t len; > > unsigned digest; > > - const char* progname; > > + char *progname; > > + bool gnu_emu =3D false; > > This file doesn=E2=80=99t currently include stdbool.h explicitly, and app= arently > that > is not implicitly included by any of the headers on Linux (and I cannot > work > out where it comes from on FreeBSD). Could you please add the explicit > include > to fix cross-building? > Sure Thanks, > Jess > >