From owner-freebsd-current@FreeBSD.ORG Thu Jun 14 11:57:37 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C26D16A469 for ; Thu, 14 Jun 2007 11:57:37 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-2.cisco.com (sj-iport-2-in.cisco.com [171.71.176.71]) by mx1.freebsd.org (Postfix) with ESMTP id 284DF13C4B7 for ; Thu, 14 Jun 2007 11:57:37 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-1.cisco.com ([171.71.179.21]) by sj-iport-2.cisco.com with ESMTP; 14 Jun 2007 04:57:37 -0700 X-IronPort-AV: i="4.16,420,1175497200"; d="scan'208"; a="379476945:sNHT48303992" Received: from sj-core-2.cisco.com (sj-core-2.cisco.com [171.71.177.254]) by sj-dkim-1.cisco.com (8.12.11/8.12.11) with ESMTP id l5EBvaTg023707; Thu, 14 Jun 2007 04:57:36 -0700 Received: from xbh-sjc-221.amer.cisco.com (xbh-sjc-221.cisco.com [128.107.191.63]) by sj-core-2.cisco.com (8.12.10/8.12.6) with ESMTP id l5EBvYaI003578; Thu, 14 Jun 2007 11:57:36 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-221.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 04:57:34 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 04:57:34 -0700 Message-ID: <46712DA2.7000901@cisco.com> Date: Thu, 14 Jun 2007 07:59:30 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <46706E63.1080906@cisco.com> <20070614022510.GA61989@rot13.obsecurity.org> <4670B1A0.4070706@cisco.com> <20070614055401.GA77538@rot13.obsecurity.org> In-Reply-To: <20070614055401.GA77538@rot13.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Jun 2007 11:57:34.0104 (UTC) FILETIME=[31ADE980:01C7AE7B] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1831; t=1181822256; x=1182686256; c=relaxed/simple; s=sjdkim1004; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20KTR=20and=20SCTP |Sender:=20; bh=+zRjpvEJgT4hzd3XdTUH1xs4lCfLfCLs1wYkXv9zJmg=; b=b6tQC5Cw2+SkTW+1vd8bm1vRWyGlWHDpPnSVccBbvrimsba0OL+gUAK97B7KdIgr/UYUxO6b /wXBTOQXpLrx8t2p4JT/0KoDAmO9U+bd5hCKbBaaXKP/F+bxJ48KPKHTaJ4cypsb4jwBzwpJXV 23g01xUE5R45HyWiFzDQWqZWk=; Authentication-Results: sj-dkim-1; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim1004 verified; ); Cc: current@freebsd.org Subject: Re: KTR and SCTP X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2007 11:57:37 -0000 Kris Kennaway wrote: > On Wed, Jun 13, 2007 at 11:10:24PM -0400, Randall Stewart wrote: > >>Kris Kennaway wrote: >> >>>On Wed, Jun 13, 2007 at 06:23:31PM -0400, Randall Stewart wrote: >>> >>> >>>>All: >>>> >>>>I am in the process of converting all the logging that >>>>SCTP does to use the KTR sub-system. This will fit >>>>nicely.. I still need to do some things to make it >>>>so I can pull out the logs and make pretty charts and >>>>graphs (in SCTP its used for debugging but also exploring >>>>how CC and other niceties works).. >>>> >>>>But I was wondering.. would anyone mind if I took >>>>KTR_SPARE2 >>>> >>>>and made it: >>>> >>>>KTR_SCTP_SUBSYS >>>> >>>>I have a huge amount of tracing under SCTP now.. so >>>>many I am setting in a seperate mask set to enable/disable >>>>various pieces of it.. So I was thinking it would >>>>warrent a sub-system of its own :-D >>>> >>>>Any objections? If not I will change it :-D >>> >>> >>>Yeah, we really do need to keep those spare fields for local use. >>> >>>Kris >>> >> >>Ok.. so I will just use >> >>KTR_SPARE2 >> >>in my logs then I guess.. :-) > > > You can't use KTR_SPARE* in committed code either, or it's no longer > spare :) You should do something like: > > i.e. do something like > > #ifdef SCTP_TRACE > #define KTR_SCTP KTR_SUBSYS > #else > #define KTR_SCTP 0 > #endif > > see the comment in > > * Two of the trace classes (KTR_DEV and KTR_SUBSYS) are special in that > * they are really placeholders so that indvidual drivers and subsystems > * can map their internal tracing to the general class when they wish to > * have tracing enabled and map it to 0 when they don't. > > Kris > k -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)