From nobody Tue Dec 6 22:55:58 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NRbPG4bZZz4k8cv; Tue, 6 Dec 2022 22:56:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NRbPG1yj0z3NTP; Tue, 6 Dec 2022 22:56:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id 2bxfpNkRwyQ9e2gr3pXfIF; Tue, 06 Dec 2022 22:56:01 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id 2gr1pxwPjomIw2gr2pwcxc; Tue, 06 Dec 2022 22:56:01 +0000 X-Authority-Analysis: v=2.4 cv=LM91/ba9 c=1 sm=1 tr=0 ts=638fc881 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=sHyYjHe8cH0A:10 a=6I5d2MoRAAAA:8 a=NEAV23lmAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Y9fz3kPoH251IsoyApQA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 66327543; Tue, 6 Dec 2022 14:55:59 -0800 (PST) Received: from slippy (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id 117DE1BB; Tue, 6 Dec 2022 14:55:59 -0800 (PST) Date: Tue, 6 Dec 2022 14:55:58 -0800 From: Cy Schubert To: Jung-uk Kim Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9a4bc5208fad - main - acpica: Import ACPICA 20221020 Message-ID: <20221206145510.35ded869@slippy> In-Reply-To: <8339f9c1-adba-7d2e-23f7-102811e3791c@FreeBSD.org> References: <202210280205.29S25MZ5011058@gitrepo.freebsd.org> <20221206173510.6CE0010D@slippy.cwsent.com> <8339f9c1-adba-7d2e-23f7-102811e3791c@FreeBSD.org> Organization: KOMQUATS X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfG/S5xQAiSgp61QQnikwz294JQx/0MBoTlQVEhomoFeR8rmXNHRKIIvZ5j6DCfoHx3RK5s9Lc9j6qDOB/4Wz7dWmV7Lz+5joCi0UBRMuIhWBY+hgPZTx jCs3ablcn1eEaR1vWqqR9lAxK+mHvRXqyyEJlQQLobKM4br4DPShu4cyH+PRa7Ns+zimEYGnG9NgCJ+AjvNyVpPewt839qoafeztefrjRa519S75hYjlzdJb 4bR2riD/CrwPeJoY1ELVXtGeJAn+bjyiHf5zjI7Jr6q8Dj5ER79W4GjhV383lzP3kUh+t5eokB6WNxsywtUNSdEoXMvzKG7XojsQuOoZUOk= X-Rspamd-Queue-Id: 4NRbPG1yj0z3NTP X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 6 Dec 2022 17:06:43 -0500 Jung-uk Kim wrote: > On 22. 12. 6., Cy Schubert wrote: > > In message <202210280205.29S25MZ5011058@gitrepo.freebsd.org>, Jung-uk Kim > > write > > s: > >> The branch main has been updated by jkim: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=9a4bc5208fad4d69360dbbe769e28a37 > >> 419c4e21 > >> > >> commit 9a4bc5208fad4d69360dbbe769e28a37419c4e21 > >> Author: Jung-uk Kim > >> AuthorDate: 2022-10-27 21:34:40 +0000 > >> Commit: Jung-uk Kim > >> CommitDate: 2022-10-28 02:03:50 +0000 > >> > >> acpica: Import ACPICA 20221020 > >> > >> (cherry picked from commit a799bdd9d50e84cd6a36e8f1d2ac4301b2a6b374) > >> --- > >> sys/contrib/dev/acpica/common/acfileio.c | 131 ++++++-- > >> sys/contrib/dev/acpica/common/adisasm.c | 4 +- > >> sys/contrib/dev/acpica/common/ahtable.c | 2 + > >> sys/contrib/dev/acpica/common/ahuuids.c | 3 + > >> sys/contrib/dev/acpica/common/dmtable.c | 116 ++++--- > >> sys/contrib/dev/acpica/common/dmtables.c | 2 +- > >> sys/contrib/dev/acpica/common/dmtbdump.c | 4 +- > >> sys/contrib/dev/acpica/common/dmtbdump1.c | 205 ++++++++++++- > >> sys/contrib/dev/acpica/common/dmtbdump2.c | 100 ++++-- > >> sys/contrib/dev/acpica/common/dmtbinfo1.c | 110 +++++++ > >> sys/contrib/dev/acpica/common/dmtbinfo2.c | 33 +- > >> sys/contrib/dev/acpica/common/dmtbinfo3.c | 17 ++ > >> sys/contrib/dev/acpica/compiler/aslcodegen.c | 75 ++++- > >> sys/contrib/dev/acpica/compiler/aslcompile.c | 12 +- > >> sys/contrib/dev/acpica/compiler/aslerror.c | 1 - > >> sys/contrib/dev/acpica/compiler/aslhelp.c | 1 + > >> sys/contrib/dev/acpica/compiler/asloptions.c | 30 +- > >> sys/contrib/dev/acpica/compiler/aslpredef.c | 2 +- > >> sys/contrib/dev/acpica/compiler/aslprune.c | 8 + > >> sys/contrib/dev/acpica/compiler/aslstartup.c | 2 +- > >> sys/contrib/dev/acpica/compiler/dtcompile.c | 42 +++ > >> sys/contrib/dev/acpica/compiler/dtcompiler.h | 10 + > >> sys/contrib/dev/acpica/compiler/dtio.c | 2 +- > >> sys/contrib/dev/acpica/compiler/dttable1.c | 128 +++++++- > >> sys/contrib/dev/acpica/compiler/dttable2.c | 169 +++++++++-- > >> sys/contrib/dev/acpica/compiler/dttemplate.h | 63 +++- > >> sys/contrib/dev/acpica/compiler/dtutils.c | 3 +- > >> .../dev/acpica/components/debugger/dbutils.c | 192 ++++++++++++ > >> sys/contrib/dev/acpica/components/events/evevent.c | 11 +- > >> .../dev/acpica/components/events/evregion.c | 8 + > >> .../dev/acpica/components/executer/exfield.c | 6 +- > >> .../dev/acpica/components/executer/exserial.c | 6 + > >> .../dev/acpica/components/hardware/hwsleep.c | 10 + > >> sys/contrib/dev/acpica/components/tables/tbdata.c | 2 +- > >> sys/contrib/dev/acpica/components/tables/tbfadt.c | 2 +- > >> sys/contrib/dev/acpica/components/tables/tbprint.c | 90 +----- > >> sys/contrib/dev/acpica/components/tables/tbutils.c | 2 +- > >> .../dev/acpica/components/tables/tbxfroot.c | 32 +- > >> .../dev/acpica/components/utilities/utcksum.c | 335 +++++++++++++++++++ > >> ++ > >> .../dev/acpica/components/utilities/utglobal.c | 1 + > >> .../dev/acpica/components/utilities/utstring.c | 10 +- > >> sys/contrib/dev/acpica/include/acconfig.h | 2 + > >> sys/contrib/dev/acpica/include/acdisasm.h | 19 ++ > >> sys/contrib/dev/acpica/include/acglobal.h | 1 + > >> sys/contrib/dev/acpica/include/acpixf.h | 2 +- > >> sys/contrib/dev/acpica/include/actables.h | 10 - > >> sys/contrib/dev/acpica/include/actbinfo.h | 10 + > >> sys/contrib/dev/acpica/include/actbl1.h | 179 ++++++++++- > >> sys/contrib/dev/acpica/include/actbl2.h | 163 +++++++++- > >> sys/contrib/dev/acpica/include/actypes.h | 9 +- > >> sys/contrib/dev/acpica/include/acutils.h | 25 ++ > >> sys/contrib/dev/acpica/include/acuuid.h | 3 +- > >> 52 files changed, 2121 insertions(+), 284 deletions(-) > > > > This broke Wake-on-LAN on my Acer laptop. Sending a WOL signal to the > > laptop fails to wake the machine. However, pulling the power cord, plugging > > it back in, and then sending a WOL signal does wake it. This led me to > > believe this commit was the cause of the problem. > > > > To remediate I applied the following patch, essentially reverting two small > > patches within this commit. This fixes my WOL problem. > > > > diff --git a/sys/contrib/dev/acpica/components/events/evevent.c > > b/sys/contrib/dev/acpica/components/events/evevent.c > > index 07c06c7c7839..1eb1262b92ea 100644 > > --- a/sys/contrib/dev/acpica/components/events/evevent.c > > +++ b/sys/contrib/dev/acpica/components/events/evevent.c > > @@ -312,8 +312,7 @@ AcpiEvFixedEventInitialize ( > > { > > Status = AcpiWriteBitRegister ( > > AcpiGbl_FixedEventInfo[i].EnableRegisterId, > > - (i == ACPI_EVENT_PCIE_WAKE) ? > > - ACPI_ENABLE_EVENT : ACPI_DISABLE_EVENT); > > + ACPI_DISABLE_EVENT); > > if (ACPI_FAILURE (Status)) > > { > > return (Status); > > @@ -437,8 +436,7 @@ AcpiEvFixedEventDispatch ( > > { > > (void) AcpiWriteBitRegister ( > > AcpiGbl_FixedEventInfo[Event].EnableRegisterId, > > - (Event == ACPI_EVENT_PCIE_WAKE) ? > > - ACPI_ENABLE_EVENT : ACPI_DISABLE_EVENT); > > + ACPI_DISABLE_EVENT); > > > > ACPI_ERROR ((AE_INFO, > > "No installed handler for fixed event - %s (%u), disabling", > > Sorry to hear. It was added by the following commit. > > https://github.com/acpica/acpica/commit/32d875705c8ee8f99fd8b78dbed48633486a7640 > > Can you please file an upstream PR? > > https://github.com/acpica/acpica/issues > > Thanks! > > Jung-uk Kim Pull request #818 has been created. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0