From owner-svn-src-head@freebsd.org Fri Oct 23 11:26:51 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A5C8443F85; Fri, 23 Oct 2020 11:26:51 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CHhlG3JZzz41Rc; Fri, 23 Oct 2020 11:26:50 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 145192602A3; Fri, 23 Oct 2020 13:26:41 +0200 (CEST) Subject: Re: svn commit: r366936 - head/sys/net To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010221222.09MCM8qo048407@repo.freebsd.org> <20201022164804.GQ2643@kib.kiev.ua> <69bfca24-40a9-552a-62b3-8ab7b46ff3c7@selasky.org> <20201023094621.GW2643@kib.kiev.ua> From: Hans Petter Selasky Message-ID: <966178e3-078f-66d3-8baa-6672b998422e@selasky.org> Date: Fri, 23 Oct 2020 13:26:04 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201023094621.GW2643@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CHhlG3JZzz41Rc X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-2.70 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-0.99)[-0.986]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.54)[-0.539]; NEURAL_HAM_MEDIUM(-0.87)[-0.873]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 11:26:51 -0000 On 2020-10-23 11:46, Konstantin Belousov wrote: > On Fri, Oct 23, 2020 at 10:04:12AM +0200, Hans Petter Selasky wrote: >> On 2020-10-22 19:54, Hans Petter Selasky wrote: >>> On 2020-10-22 18:48, Konstantin Belousov wrote: >>>> sys/systm.h already includes sys/param.h.  Also, sys/param.h already >>>> includes >>>> sys/types.h. >>> >>> I'll have a look tomorrow at this. Thanks for pointing out. >> >> It appears sys/systm.h needs sys/types.h included first: > Normally you do > #include > #include > and I do not see why it would not work in this case. > >> >>> In file included from /usr/img/freebsd.svn/src/sys/sys/systm.h:44: >>> ./machine/atomic.h:230:1: error: unknown type name 'u_char'; did you mean 'char'? >>> ATOMIC_CMPSET(char); >> >> --HPS Hi, The following works, but it doesn't make much difference. Do we have a script or tool, which can do this? --HPS > Index: sys/net/if_infiniband.c > =================================================================== > --- sys/net/if_infiniband.c (revision 366936) > +++ sys/net/if_infiniband.c (working copy) > @@ -30,9 +30,8 @@ > __FBSDID("$FreeBSD$"); > > #include > +#include > #include > -#include > -#include > #include > #include > #include