From owner-cvs-all  Wed Oct 11 16:46:38 2000
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4A6EE37B502; Wed, 11 Oct 2000 16:46:35 -0700 (PDT)
Received: (from gibbs@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id QAA99501;
	Wed, 11 Oct 2000 16:46:35 -0700 (PDT)
	(envelope-from gibbs@FreeBSD.org)
Message-Id: <200010112346.QAA99501@freefall.freebsd.org>
From: "Justin T. Gibbs" <gibbs@FreeBSD.org>
Date: Wed, 11 Oct 2000 16:46:35 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/dev/aic7xxx aic7xxx.c aic7xxx.h
         aic7xxx_freebsd.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

gibbs       2000/10/11 16:46:35 PDT

  Modified files:
    sys/dev/aic7xxx      aic7xxx.c aic7xxx.h aic7xxx_freebsd.c 
  Log:
  Store a pointer to our softc in the kernel's SCB structure.  In the
  past we stored this data in the CCB and attained the CCB via a pointer
  in the SCB.  In ahc_timeout(), however, the timedout SCB may have already
  been completed (inherent race), meaning that the CCB could have been recycled,
  and the ahc pointer reset.
  
  Clean up the logic in ahc_search_qinfifo that deals with the busy device
  table.  For some reason it assumed that the only valid time to search
  to see if additional lun entries should be checked was if lun 0 matched.
  Now we properly itterate through the necessary luns.  The busy device
  table is used to detect invalid reselections, so a device would have had
  to perform an unexpected reselection for this to cause problems.  Further,
  all luns are collapsed to a single entry unless we have external ram
  with large SCBs (3940AU models) so the chance of this happening was
  rather remote.
  
  Clean up the logic for dealing with the untagged queues.  We now set a
  flag in the SCB that indicates that it is on the untagged queue instead
  of inferring this from the type and setup of the CCB pased into us by
  CAM.
  
  In ahc_timeout(), don't print the path of the SCB until the controller
  is paused and we are sure that it has not completed yet.  This, in
  conjunction with referencing the ahc pointer in the SCB rather than
  the CCB in the SCB avoids panics in the case of a timedout scb completing
  just before the timeout handler runs.  This turns out to be guaranteed
  if interrupt delivery is failing, as we run our interrupt handler to
  flush any "just missed events" when a timeout occurs.  Mention the
  likelyhood of broken interrupts if a timedout SCB is completed by
  our call to ahc_intr().
  
  Revision  Changes    Path
  1.56      +25 -33    src/sys/dev/aic7xxx/aic7xxx.c
  1.28      +3 -1      src/sys/dev/aic7xxx/aic7xxx.h
  1.11      +8 -12     src/sys/dev/aic7xxx/aic7xxx_freebsd.c



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message