Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jun 2022 07:22:39 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Hans Petter Selasky <hps@selasky.org>, "Bjoern A. Zeeb" <bz@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 9fd0d9b16e93 - main - ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP kernel configurations.
Message-ID:  <5a3bd99e-bd7a-7b89-7d11-a821b3d19fac@FreeBSD.org>
In-Reply-To: <eba2a833-d7b5-7ba1-8afb-b05283002983@selasky.org>
References:  <202206111932.25BJW6w6040018@gitrepo.freebsd.org> <alpine.BSF.2.00.2206112003291.68830@ai.fobar.qr> <eba2a833-d7b5-7ba1-8afb-b05283002983@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/12/22 4:43 AM, Hans Petter Selasky wrote:
> On 6/11/22 22:04, Bjoern A. Zeeb wrote:
>> On Sat, 11 Jun 2022, Hans Petter Selasky wrote:
>>
>>> The branch main has been updated by hselasky:
>>>
>>> URL:
>>> https://cgit.FreeBSD.org/src/commit/?id=9fd0d9b16e93ff2a3bd375a98763dca0150dcee0
>>>
>>>
>>> commit 9fd0d9b16e93ff2a3bd375a98763dca0150dcee0
>>> Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
>>> AuthorDate: 2022-06-11 19:29:42 +0000
>>> Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
>>> CommitDate: 2022-06-11 19:31:28 +0000
>>>
>>>     ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP
>>> kernel configurations.
>>>
>>>     Kernel TLS depends on INET or INET6 being enabled.
>>
>> That is only a short-term solution hiding the actual problem and will
>> now propably never be fixed again like these device drivers which were
>> on that list ofr ages...
> 
> +1
> 
> There is a plan to replace config at some point. I believe this is a
> limitation of sys/conf/files, that it doesn't provide a good way to
> handle conflicts. There are many ifdef KERN_TLS, so just skipping one
> file for building won't help.
> 
> https://hackmd.io/w1Tf8mmVQVuZok7-LNEhgw

What we often do though is just add in #ifdef's to make a given file a
kind of stub.  In theory KTLS could work over UNIX domain sockets if
someone wanted to do the work, and that would just entail adding the
right #ifdef INET, etc. in this file.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5a3bd99e-bd7a-7b89-7d11-a821b3d19fac>