From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 17 02:50:30 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A05CE16A494 for ; Tue, 17 Oct 2006 02:50:30 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F90543D62 for ; Tue, 17 Oct 2006 02:50:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9H2oNgl017378 for ; Tue, 17 Oct 2006 02:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9H2oNuF017377; Tue, 17 Oct 2006 02:50:23 GMT (envelope-from gnats) Date: Tue, 17 Oct 2006 02:50:23 GMT Message-Id: <200610170250.k9H2oNuF017377@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Bruce Evans Cc: Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bruce Evans List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2006 02:50:30 -0000 The following reply was made to PR kern/104436; it has been noted by GNATS. From: Bruce Evans To: Cheng-Lung Sung Cc: John Baldwin , freebsd-hackers@freebsd.org, freebsd-current@freebsd.org, freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h Date: Tue, 17 Oct 2006 12:41:04 +1000 (EST) On Tue, 17 Oct 2006, Cheng-Lung Sung wrote: > On Mon, Oct 16, 2006 at 02:31:24PM -0400, John Baldwin wrote: >> Is this better? >> ... > Thanks, I didn't go through the whole sem.h. > Also, it seems we should put these parts before 'sturct semid_ds'. > or say, after we include sys/ipc.h (which include sys/_types.h) Yes, that is especially needed for time_t, since it is the only one of the typedef'ed types used early in sys/sem.h. The others might be needed later when the non-typedefed types are cleaned up. (sys/ipc.h needs cleaning up more. It still spells uid_t as "unsigned short", but uids aren't that short...) Bruce