From owner-p4-projects@FreeBSD.ORG Mon Jul 9 20:48:36 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9F8AC16A46D; Mon, 9 Jul 2007 20:48:36 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4063A16A421; Mon, 9 Jul 2007 20:48:36 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 2C94713C458; Mon, 9 Jul 2007 20:48:36 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id A3EB51A4D86; Mon, 9 Jul 2007 13:48:35 -0700 (PDT) Date: Mon, 9 Jul 2007 13:48:35 -0700 From: Alfred Perlstein To: Peter Wemm Message-ID: <20070709204835.GG45894@elvis.mu.org> References: <200706302226.l5UMQXfP002249@repoman.freebsd.org> <20070709193926.GF45894@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070709193926.GF45894@elvis.mu.org> User-Agent: Mutt/1.4.2.3i Cc: Perforce Change Reviews Subject: Re: PERFORCE change 122592 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2007 20:48:37 -0000 * Alfred Perlstein [070709 12:39] wrote: > Peter, why not have libc obtain this at startup and cache it? > > Otherwise these syscalls will incur an additional sysctl per > call, right? duh, saw your later changes... I'm assuming those pretty much address that concern. thanks, -Alfred > > -Alfred > > * Peter Wemm [070630 15:26] wrote: > > http://perforce.freebsd.org/chv.cgi?CH=122592 > > > > Change 122592 by peter@peter_overcee on 2007/06/30 22:25:38 > > > > Use getosreldate() to test for __new_* syscalls. > > > > Affected files ... > > > > .. //depot/projects/hammer/lib/libc/sys/ftruncate.c#3 edit > > .. //depot/projects/hammer/lib/libc/sys/lseek.c#3 edit > > .. //depot/projects/hammer/lib/libc/sys/mmap.c#4 edit > > .. //depot/projects/hammer/lib/libc/sys/pread.c#3 edit > > .. //depot/projects/hammer/lib/libc/sys/pwrite.c#3 edit > > .. //depot/projects/hammer/lib/libc/sys/truncate.c#3 edit > > > > Differences ... > > > > ==== //depot/projects/hammer/lib/libc/sys/ftruncate.c#3 (text+ko) ==== > > > > @@ -36,6 +36,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -47,5 +48,8 @@ > > off_t length; > > { > > > > - return(__syscall((quad_t)SYS_ftruncate, fd, 0, length)); > > + if (getosreldate() >= 700049) > > + return(__new_ftruncate(fd, length)); > > + else > > + return(__syscall((quad_t)SYS_ftruncate, fd, 0, length)); > > } > > > > ==== //depot/projects/hammer/lib/libc/sys/lseek.c#3 (text+ko) ==== > > > > @@ -36,6 +36,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -47,5 +48,9 @@ > > off_t offset; > > int whence; > > { > > - return(__syscall((quad_t)SYS_lseek, fd, 0, offset, whence)); > > + > > + if (getosreldate() >= 700049) > > + return(__new_lseek(fd, offset, whence)); > > + else > > + return(__syscall((quad_t)SYS_lseek, fd, 0, offset, whence)); > > } > > > > ==== //depot/projects/hammer/lib/libc/sys/mmap.c#4 (text+ko) ==== > > > > @@ -37,6 +37,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -52,6 +53,10 @@ > > off_t offset; > > { > > > > - return ((void *)(intptr_t)__syscall((quad_t)SYS_mmap, addr, len, prot, > > - flags, fd, 0, offset)); > > + if (getosreldate() >= 700049) > > + return (__new_mmap(addr, len, prot, flags, fd, offset)); > > + else > > + > > + return ((void *)(intptr_t)__syscall((quad_t)SYS_mmap, addr, len, prot, > > + flags, fd, 0, offset)); > > } > > > > ==== //depot/projects/hammer/lib/libc/sys/pread.c#3 (text+ko) ==== > > > > @@ -36,6 +36,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -48,5 +49,9 @@ > > size_t nbyte; > > off_t offset; > > { > > - return ((ssize_t)__syscall((quad_t)SYS_pread, fd, buf, nbyte, 0, offset)); > > + > > + if (getosreldate() >= 700049) > > + return (__new_pread(fd, buf, nbyte, offset)); > > + else > > + return ((ssize_t)__syscall((quad_t)SYS_pread, fd, buf, nbyte, 0, offset)); > > } > > > > ==== //depot/projects/hammer/lib/libc/sys/pwrite.c#3 (text+ko) ==== > > > > @@ -36,6 +36,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -48,5 +49,8 @@ > > size_t nbyte; > > off_t offset; > > { > > - return ((ssize_t)__syscall((quad_t)SYS_pwrite, fd, buf, nbyte, 0, offset)); > > + if (getosreldate() >= 700049) > > + return (__new_pwrite(fd, buf, nbyte, offset)); > > + else > > + return ((ssize_t)__syscall((quad_t)SYS_pwrite, fd, buf, nbyte, 0, offset)); > > } > > > > ==== //depot/projects/hammer/lib/libc/sys/truncate.c#3 (text+ko) ==== > > > > @@ -35,8 +35,8 @@ > > > > #include > > #include > > - > > #include > > +#include > > > > /* > > * This function provides 64-bit offset padding that > > @@ -48,5 +48,8 @@ > > off_t length; > > { > > > > - return(__syscall((quad_t)SYS_truncate, path, 0, length)); > > + if (getosreldate() >= 700049) > > + return(__new_truncate(path, length)); > > + else > > + return(__syscall((quad_t)SYS_truncate, path, 0, length)); > > } > > -- > - Alfred Perlstein -- - Alfred Perlstein