From nobody Mon Jun 13 14:28:17 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 13D8783DD5D; Mon, 13 Jun 2022 14:28:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMDSf75hWz3vdf; Mon, 13 Jun 2022 14:28:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655130499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOqU2dovmyJhyddIzSP2x/qK5JNIr0mA+XV7rhZTIA4=; b=lhwSXnQH2hol/x3vHsY5epTOclZ8CYtowQ6SICiwSZvAc6sugpz2uIHUlEIHm+PEBUqvFf 8Pk7bO1GbHwp1RSQsw48+EpdoLSsQgztdItGpVLsCcHj7xlJeNhaedgZ+y5rzChV6WjSek YcZhD0nbFBqYLyiEs0/v3hUdgUxIWmgIgUh3D2SWO5zY8fI3lEtikoJgja0HwFu0SdNIJk pHdmlXi/WfnglvKKKo0SMeI2iA3q6afBzZD06+OJmt5aYnGEFyZ2nSZNPQnObvMk6eSFJ7 /Z3y6z0pBdOyfDdCZiXlImepSt0pcKBPDRQEdD31YF03cWIOLrx61wqACKTx7Q== Received: from [IPV6:2601:648:8680:ed60:d176:6ba6:4601:2b26] (unknown [IPv6:2601:648:8680:ed60:d176:6ba6:4601:2b26]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 5246A2C7AA; Mon, 13 Jun 2022 14:28:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 13 Jun 2022 07:28:17 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part Content-Language: en-US To: "Bjoern A. Zeeb" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655130499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOqU2dovmyJhyddIzSP2x/qK5JNIr0mA+XV7rhZTIA4=; b=tkaxkCXNZNEfReYh7Oe4bTmMH/O9HFIOjZRe0vtHgjqrHwGV3yvnoDbjuZ1//8qLlBMt8y UXwr/WaNMJoLuy8YWDP/2uYZDkFhYXJIofSImt+USWqGgdbB5GjpaBoMuzrb5Qsj/ZIoJP QYrJxADb+CRVZUJjcyth+4vF2h1E9VFSOBU2/K6D18DHaWiGmMikWrhF1C2e04n3jg3L3H UTrWmnqMjB02CJve1TYJHm+38bQQbEA3E008BuYva6ruC9GUfu9eJut/rkiwbvduThA+Kh rbxrS2mZ5wyxBGpKEuyh4kOUD7pVtcR3TRTU+5ZLUzvO+/koolzqmAIqyBtUDg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655130499; a=rsa-sha256; cv=none; b=V5ZNsVCKl9FGr9xfWIWUQNPy7F6WCiqjj9qn9QXab5NgmesiV0NSxSgUTYlxtiUpw4j4i2 BJGiBZRf9br5xvCGfXUGnGoHazbY0rCcu76CyuDPvoLDP3WzDqavkqI4a6jfVKAFjfr4GL sXreJlNGOkcQs9cf/VtkVwLDLUYmv5LC43EwQP7C416tZOfqqNGoNd5J90qOvLE+oXnrG5 WUdVXuMlcPU+X3nIhPH9OGLZaMHfAFb/m2JbWYtvIzE1L3afdx9UdA0hIe5H6ZnFJkl7w+ APsXW2I/Mu3xjdDRmIa3fTlcwIGFdMXrMj/O3f23wY6Us36A5Ee4pAsFYLgZ4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea > > commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea > Author: Bjoern A. Zeeb > AuthorDate: 2022-06-12 18:35:58 +0000 > Commit: Bjoern A. Zeeb > CommitDate: 2022-06-12 18:35:58 +0000 > > rtw88: split driver up into a core and pci part > > Split the driver up into two modules (if_rtw88_pci.ko and rtw88_core.ko). > This is in preparation for the hopefully eventually upcoming USB support > using the same driver core. > > Note: this changes the module name to load to if_rtw88_pci.ko instead of > if_rtw88.ko. If using devmatch(8) everything should stay the same as > the driver name (used for net.wlan.devices) stays rtw88. If using > kld_list in rc.conf or loader.conf you will need to adjust the name. > Update man page for this. > > MFC after: 3 days This sort of split in a .ko is kind of rare for drivers in the tree that support multiple bus attachments. Usually we just lump all the attachments into the same .ko. It's true that with the death of ISA, etc. we no longer have as many drivers with multiple bus attachments, but the norm has been to include them all in a single .ko. Is there a reason you can't follow the normal practice here? -- John Baldwin