From owner-svn-src-head@freebsd.org Wed May 30 09:43:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71ABBF7C10C; Wed, 30 May 2018 09:43:04 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED3A979323; Wed, 30 May 2018 09:43:03 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A34D8260174; Wed, 30 May 2018 11:43:01 +0200 (CEST) Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool To: Antoine Brodin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805280812.w4S8CI56046943@repo.freebsd.org> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> <56e03042-872c-36df-4fea-d22a09d7ffca@selasky.org> From: Hans Petter Selasky Message-ID: Date: Wed, 30 May 2018 11:42:48 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 09:43:04 -0000 On 05/30/18 11:00, Antoine Brodin wrote: > On Wed, May 30, 2018 at 8:20 AM, Hans Petter Selasky wrote: >> On 05/30/18 10:02, Antoine Brodin wrote: >>> >>> Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE >>> as it previously had? >> >> >> The HAVE_REMOTE was removed upstream: >> >> https://github.com/the-tcpdump-group/libpcap/commit/a372536befc9b1ee1d355058daa2eb9f66aa0c59#diff-46964bcbd8e8a5cec9a75c66ab26a97b >> >> What do you think? Shall we re-add it to base? Hi, > Either hide remote packet capture functions from the header or enable > remote capture functions? This feature is disabled by default for UNIX. > Note that net/p5-Net-Pcap will fail to build with libpcap from ports > too when libpcap from ports is updated to version 1.9.0 (pre-release). No, libpcap from ports has own header files and libraries and does not use anything from libpcap in base. Enabling remote packet capture in libcap won't solve the build failure. The right solution from my point of view is to extend the BUILD_DEPENDS and CFLAGS and LDFLAGS like shown: BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ libpcap>=0:net/libpcap CFLAGS+= -I${PREFIX}/include LDFLAGS+= -L${PREFIX}/lib After the upgrade to 1.9.0 (pre-release) in ports you simply add: CFLAGS+= -DHAVE_PCAP_SETSAMPLING -DHAVE_PCAP_OPEN --HPS