From owner-freebsd-current@FreeBSD.ORG  Wed Sep 19 22:58:04 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84F1516A420;
	Wed, 19 Sep 2007 22:58:04 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from mojo.ru (mojo.ru [84.252.152.63])
	by mx1.freebsd.org (Postfix) with ESMTP id EE83713C461;
	Wed, 19 Sep 2007 22:58:03 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from [192.168.0.16] (nc-76-4-28-21.dhcp.embarqhsd.net [76.4.28.21])
	(authenticated bits=0)
	by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l8JMwCiR027243
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 20 Sep 2007 02:58:14 +0400
Message-ID: <46F1A96F.2040602@FreeBSD.org>
Date: Wed, 19 Sep 2007 18:57:51 -0400
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
Organization: Google Summer of Code 2007 Student @ The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB;
	rv:1.7.5) Gecko/20041217
X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <200709132302.l8DN2Tv5076033@repoman.freebsd.org>
	<46E9FC0C.70607@FreeBSD.org>
	<alpine.BSF.0.9999.0709182210210.1003@ync.qbhto.arg>
In-Reply-To: <alpine.BSF.0.9999.0709182210210.1003@ync.qbhto.arg>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexander Leidinger <Alexander@leidinger.net>,
	Shteryana Shopova <syrinx@FreeBSD.org>, freebsd-current@FreeBSD.org,
	"Constantine A. Murenin" <cnst@FreeBSD.org>
Subject: Re: GSoC2007: cnst-sensors.2007-09-13.patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2007 22:58:04 -0000

On 19/09/2007 01:13, Doug Barton wrote:
> On Thu, 13 Sep 2007, Constantine A. Murenin wrote:
> 
>> Dear freebsd-{arch,current,hackers}@,
>>
>> On this 256th day of 2007, it is my great pleasure to announce the 
>> completion of my GSoC2007 project on porting the sysctl hardware 
>> sensors framework from OpenBSD to FreeBSD.
> 
> 
> This works great on my C2D:
> 
> hw.sensors.cpu0.temp0: 79.00 degC
> hw.sensors.cpu1.temp0: 82.00 degC
> 
> Sensor                            Value      Status       Description
> cpu0.temp0                   82.00 degC
> cpu1.temp0                   84.00 degC
> 
> (the temp went up because I was compiling something).

Thanks for testing!

> Two small comments about the rc.d stuff. First, the empty _flags 
> variable in defaults/rc.conf should be commented out. Second, the rc.d 

How so?  I don't see any other empty _flags variables in 
defaults/rc.conf being commented out.

> script needs the shutdown KEYWORD.

Similarly, I don't see why this is needed -- it was not used by the 
scripts on which this script was based on (the history is in p4). 
Reading through rc(8) doesn't seem to suggest that this keyword would 
actually be applicable here.

Cheers,
Constnatine.