From nobody Mon Jun 13 14:32:51 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8CF1083F58B for ; Mon, 13 Jun 2022 14:33:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMDZ652Y3z4RLY for ; Mon, 13 Jun 2022 14:33:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92e.google.com with SMTP id r9so2190555uaf.13 for ; Mon, 13 Jun 2022 07:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p4DRrFRMvRzPCGbAGM/54/FK0sLHTCiNiY6RFYlyRV0=; b=oHGhum6zxYp2op5EONtTCYVTXBN4iEcvn3sISVnps8QYkJ+SFP1XwKq9BGFsMfb6ee Q2ABRa9YRlt6UBKXf+LHkMMnF7G+Q/Hm4KriJOg0L+4L2Oa1EtMMxEsjUPSOLVgU+5WM Ze15RnD4C9nnsiTBLwoVZTSqpxEzdXcFHwjImZtuERnClz+dalXqmxBl8ZAuOleUTR2k yeMLU93qMZg1gasGEBuZe4YQvirZk5tiVXa1IdbZRU1ffh4MYb5hsteIw/5vj7Udlqf+ VxW4aRPe3Fv4zw3BLaPAuF4N7CGsAoTFaAUXgqgdEXRPvsF3Sba85fTOf6aAKho9wgVI 9lOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p4DRrFRMvRzPCGbAGM/54/FK0sLHTCiNiY6RFYlyRV0=; b=O8v8d6p+A8SolWh0xQttXEByYr7r6V5MnfNCKC3suRRTS+0bsRojCwxoAcT4t11Bwl O0UzBA2vuHQPrxA1o4YZ5F0wB4o5dn4LaKesPvymQtVPaoYjyLY85JWebj2/JCjE7CmL NKp2g7lY2ckV17Ot7fcenwGIQgt5mfh6PCKLMccLSQbwgC9OTEN5fkfC7RKFDzayUHVO ZtsTj4sbgDi9Vl/4CX4yaDPcGul5mv76xpR8zjWBOjGMvXhEBUerQmf9PMxIW7cJbCAq LK6XRa9nPo1dEGobtHPRHkU0yoAAL4cZQ8eHR7vWlWrrHNhqWiFbf1VPCcFM7g+6piSG oUSQ== X-Gm-Message-State: AOAM5303J2qLAeYye43+pBJGBU9Fv13DHcSLq7vcAylVktVDJbdnFcVX Rz0ubiFN4o/Vq0Ot7dVDS9KLDfliDqdwVrDGGvVVZw== X-Google-Smtp-Source: ABdhPJy2sD6QXAfhcdWwV1jvXbqZ4Jwg2ebmPhB57hIhc5J1ToXjuQyOFwVEWBa2iTahburSad7/d02y7aP7UJ3EiU8= X-Received: by 2002:ab0:6907:0:b0:371:521c:7a1c with SMTP id b7-20020ab06907000000b00371521c7a1cmr28888109uas.48.1655130781908; Mon, 13 Jun 2022 07:33:01 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 13 Jun 2022 08:32:51 -0600 Message-ID: Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part To: John Baldwin Cc: "Bjoern A. Zeeb" , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000050146a05e1552a8a" X-Rspamd-Queue-Id: 4LMDZ652Y3z4RLY X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=oHGhum6z; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::92e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::92e:from]; MLMMJ_DEST(0.00)[dev-commits-src-all]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --00000000000050146a05e1552a8a Content-Type: text/plain; charset="UTF-8" On Mon, Jun 13, 2022, 8:28 AM John Baldwin wrote: > On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote: > > The branch main has been updated by bz: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea > > > > commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea > > Author: Bjoern A. Zeeb > > AuthorDate: 2022-06-12 18:35:58 +0000 > > Commit: Bjoern A. Zeeb > > CommitDate: 2022-06-12 18:35:58 +0000 > > > > rtw88: split driver up into a core and pci part > > > > Split the driver up into two modules (if_rtw88_pci.ko and > rtw88_core.ko). > > This is in preparation for the hopefully eventually upcoming USB > support > > using the same driver core. > > > > Note: this changes the module name to load to if_rtw88_pci.ko > instead of > > if_rtw88.ko. If using devmatch(8) everything should stay the same > as > > the driver name (used for net.wlan.devices) stays rtw88. If using > > kld_list in rc.conf or loader.conf you will need to adjust the name. > > Update man page for this. > > > > MFC after: 3 days > > This sort of split in a .ko is kind of rare for drivers in the tree that > support > multiple bus attachments. Usually we just lump all the attachments into > the same > .ko. It's true that with the death of ISA, etc. we no longer have as many > drivers > with multiple bus attachments, but the norm has been to include them all > in a > single .ko. Is there a reason you can't follow the normal practice here? > Agreed. Furthermore, in the past when a couple of drivers did the we had issues and confusion. Please don't MFC until this discussion is done. Warner > --00000000000050146a05e1552a8a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jun 13, 2022, 8:28 AM John Baldwin <jhb@freebsd.org> wrote:
On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote:
> The branch main has been updated by bz:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D0f7b9777f8f39fbc230b3e1de2f844= d9f839adea
>
> commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea
> Author:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@FreeBSD.org>
> AuthorDate: 2022-06-12 18:35:58 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@FreeBSD.org>
> CommitDate: 2022-06-12 18:35:58 +0000
>
>=C2=A0 =C2=A0 =C2=A0 rtw88: split driver up into a core and pci part >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Split the driver up into two modules (if_rtw88_pci= .ko and rtw88_core.ko).
>=C2=A0 =C2=A0 =C2=A0 This is in preparation for the hopefully eventuall= y upcoming USB support
>=C2=A0 =C2=A0 =C2=A0 using the same driver core.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Note: this changes the module name to load to if_r= tw88_pci.ko instead of
>=C2=A0 =C2=A0 =C2=A0 if_rtw88.ko.=C2=A0 If using devmatch(8) everything= should stay the same as
>=C2=A0 =C2=A0 =C2=A0 the driver name (used for net.wlan.devices) stays = rtw88.=C2=A0 If using
>=C2=A0 =C2=A0 =C2=A0 kld_list in rc.conf or loader.conf you will need t= o adjust the name.
>=C2=A0 =C2=A0 =C2=A0 Update man page for this.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 3 days

This sort of split in a .ko is kind of rare for drivers in the tree that su= pport
multiple bus attachments.=C2=A0 Usually we just lump all the attachments in= to the same
.ko.=C2=A0 It's true that with the death of ISA, etc. we no longer have= as many drivers
with multiple bus attachments, but the norm has been to include them all in= a
single .ko.=C2=A0 Is there a reason you can't follow the normal practic= e here?

Agreed. Furthermore, in the past when a couple of drivers did the we= had issues and confusion. Please don't MFC until this discussion is do= ne.=C2=A0

Warner=C2=A0
--00000000000050146a05e1552a8a--