From owner-freebsd-current@FreeBSD.ORG Fri Sep 29 15:56:08 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 323C816A40F; Fri, 29 Sep 2006 15:56:08 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 279CC43D76; Fri, 29 Sep 2006 15:56:06 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 2765845CDA; Fri, 29 Sep 2006 17:56:05 +0200 (CEST) Received: from localhost (dka128.neoplus.adsl.tpnet.pl [83.24.4.128]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 8502C45B26; Fri, 29 Sep 2006 17:55:59 +0200 (CEST) Date: Fri, 29 Sep 2006 17:55:26 +0200 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20060929155526.GA9194@garage.freebsd.pl> References: <20060929141709.E70454@fledge.watson.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20060929141709.E70454@fledge.watson.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: ru@FreeBSD.org, current@FreeBSD.org Subject: Re: lockf in installworld -- not a good idea X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2006 15:56:08 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 29, 2006 at 02:20:06PM +0100, Robert Watson wrote: > I've noticed an increasing intolerance in our tools for system install an= d maintenance to locking not being implemented over the past few years. I = no longer get working=20 > cron on boxes with neither rpc.lockd nor local locking enabled, for > example. [...] If you are refering to my change in which cron(8) started to use pidfile(3), then I'm sorry, but you're wrong. cron(8) from the very beginning was exiting when it had problems with creating a pidfile, please check function acquire_daemonlock() in: http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/cron/lib/misc.c?rev=3D1= =2E1&content-type=3Dtext/x-cvsweb-markup My pidfile(3) commit is here: http://lists.freebsd.org/pipermail/cvs-all/2005-August/132374.html Where I try to explain cron(8)'s behaviour. The way I prefer is to ignore errors other than EEXIST - you can check EXAMPLES section in the pidfile(3) manual page for more info. I just didn't wanted to change cron(8)'s original behaviour. I do agree, that this shouldn't be treated as critical error and I can change it if you like. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFHUHuForvXbEpPzQRAptxAJwNKqMTFt6BdTBq0EHdO8ZLItZYVwCgxfQX HSA3kSX8MQ5HOvSaF9lPWeE= =qTCH -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--