Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Jun 2012 07:52:43 +0200
From:      =?ISO-8859-1?Q?Fernando_Apestegu=EDa?= <fernando.apesteguia@gmail.com>
To:        freebsd-ports@freebsd.org
Subject:   Re: 'make extract' downloads already downloaded file
Message-ID:  <CAGwOe2YCaOi9BH798MFoQ_Ym3cprxtaZLsJRSJiGc-pPkBrcDg@mail.gmail.com>
In-Reply-To: <CAGwOe2YSkXckkK4JTrxPS1ULAKLE70qPCmUcORSLzU7qg0v00Q@mail.gmail.com>
References:  <CAGwOe2YSkXckkK4JTrxPS1ULAKLE70qPCmUcORSLzU7qg0v00Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 5, 2012 at 7:12 PM, Fernando Apestegu=EDa
<fernando.apesteguia@gmail.com> wrote:
> Hi all,
>
> I'm having a problem with a port I am currently maintaining. This is
> the log from pointyhat:
>
> erwin@freefall:cad/openvsp> make fetch
> =3D=3D=3D> =A0License check disabled, port has not defined LICENSE
> /usr/bin/fetch -o /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_2.0_Community
> /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz =A0100% of 2808 kB 1271 kBps
> erwin@freefall:cad/openvsp> make extract
> =3D=3D=3D> =A0License check disabled, port has not defined LICENSE
> /usr/bin/fetch -o /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_2.0_Community
> /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz =A0100% of 2808 kB 1208 kBps
> =3D=3D=3D> =A0Extracting for openvsp-2.0_1
> =3D> SHA256 Checksum OK for OpenVSP_2.0_Community.tar.gz.
> erwin@freefall:cad/openvsp>
>
> This[1] is the current Makefile
>
> According to Erwin there's something wrong with the redefinition of
> DISTNAME and do-fetch that confuses the infrastructure. I tried to do
> the same thing I do in another port I maintain, math/dynare[2] which
> doesn't suffer this problem. This is the Makefile I'm working on:

Correction: math/dynare suffers the same problem.

I finally have a fix for this (check for the presence of DISTNAME in DISTDI=
R
before trying to download the file).

Thanks.

>
>
> # Port makefile for: =A0 =A0openvsp
> # Date created: =A0 =A0 =A0 =A0 Apr 10 2012
> # Whom: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Fernando Apesteguia <fernando.ape=
steguia@gmail.com>
> #
> # $FreeBSD$
>
> PORTNAME=3D =A0 =A0 =A0 openvsp
> PORTVERSION=3D =A0 =A02.0
> CATEGORIES=3D =A0 =A0 cad
> MASTER_SITES=3D
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_${PORTVERSION=
}_Community
>
> MAINTAINER=3D =A0 =A0 fernando.apesteguia@gmail.com
> COMMENT=3D =A0 =A0 =A0 =A0Create a 3D model of an aircraft defined by
> engineering parameters
>
> BUILD_DEPENDS=3D =A0${LOCALBASE}/lib/libopenNURBS.a:${PORTSDIR}/graphics/=
opennurbs
>
> LIB_DEPENDS+=3D =A0 fltk:${PORTSDIR}/x11-toolkits/fltk
> LIB_DEPENDS+=3D =A0 xml2:${PORTSDIR}/textproc/libxml2
> LIB_DEPENDS+=3D =A0 jpeg:${PORTSDIR}/graphics/jpeg
> LIB_DEPENDS+=3D =A0 png:${PORTSDIR}/graphics/png
> LIB_DEPENDS+=3D =A0 Xinerama:${PORTSDIR}/x11/libXinerama
> LIB_DEPENDS+=3D =A0 Xft:${PORTSDIR}/x11-fonts/libXft
>
> WRKSRC=3D =A0 =A0 =A0 =A0 ${WRKDIR}/OpenVSP-OpenVSP-574d7c3/src
>
> USE_CMAKE=3D =A0 =A0 =A0yes
> USE_DOS2UNIX=3D =A0 yes
>
> EXAMPLESDIR=3D =A0 =A0${PREFIX}/share/examples/openvsp
>
> do-fetch:
> =A0 =A0 =A0 =A0fetch -o ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX} ${MASTER_SI=
TES}
>
> do-install:
> =A0 =A0 =A0 =A0@${INSTALL_PROGRAM} ${WRKSRC}/vsp/vsp ${PREFIX}/bin
> =A0 =A0 =A0 =A0@${MKDIR} ${EXAMPLESDIR}
> .for i in airfoil cabin fonts fuselage models setup textures
> =A0 =A0 =A0 =A0@${MKDIR} ${EXAMPLESDIR}/${i}
> =A0 =A0 =A0 =A0@${INSTALL_DATA} ${WRKSRC}/../examples/${i}/* ${EXAMPLESDI=
R}/${i}
> .endfor
>
> .include <bsd.port.mk>
>
> Still, after a 'make checksum', invoking a 'make extract' causes the
> tarball to be downloaded again. I checked and the file exists in
> /usr/ports/distfiles
>
> Any ideas of what the problem is?
>
> Thanks in advance.
>
>
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/cad/openvsp/Makefile?rev=
=3D1.2;content-type=3Dtext%2Fplain
> [2] http://www.freebsd.org/cgi/cvsweb.cgi/ports/math/dynare/Makefile?rev=
=3D1.5;content-type=3Dtext%2Fplain



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YCaOi9BH798MFoQ_Ym3cprxtaZLsJRSJiGc-pPkBrcDg>