From owner-dev-commits-src-main@freebsd.org Tue Jan 19 20:16:48 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0139A4DE30D; Tue, 19 Jan 2021 20:16:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DL0L76grmz4f6w; Tue, 19 Jan 2021 20:16:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D8A084A4A; Tue, 19 Jan 2021 20:16:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 10JKGlmM073836; Tue, 19 Jan 2021 20:16:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 10JKGlOa073835; Tue, 19 Jan 2021 20:16:47 GMT (envelope-from git) Date: Tue, 19 Jan 2021 20:16:47 GMT Message-Id: <202101192016.10JKGlOa073835@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Toomas Soome Subject: git: 4bbfe4bf08d6 - main - loader: comment on rgb_to_color_index() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4bbfe4bf08d6d16ae65729bb22159c8dbd1027bd Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 20:16:48 -0000 The branch main has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=4bbfe4bf08d6d16ae65729bb22159c8dbd1027bd commit 4bbfe4bf08d6d16ae65729bb22159c8dbd1027bd Author: Toomas Soome AuthorDate: 2021-01-13 16:38:08 +0000 Commit: Toomas Soome CommitDate: 2021-01-19 20:15:26 +0000 loader: comment on rgb_to_color_index() Add small comment block about rgb_to_color_index(). --- stand/common/gfx_fb.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/stand/common/gfx_fb.c b/stand/common/gfx_fb.c index d98e6d1bae4b..08c0f59505f2 100644 --- a/stand/common/gfx_fb.c +++ b/stand/common/gfx_fb.c @@ -303,7 +303,13 @@ gfx_fb_color_map(uint8_t index) return (rgb_color_map(index, rmask, 16, gmask, 8, bmask, 0)); } -/* Get indexed color */ +/* + * Get indexed color from RGB. This function is used to write data to video + * memory when the adapter is set to use indexed colors. + * Since UEFI does only support 32-bit colors, we do not implement it for + * UEFI because there is no need for it and we do not have palette array + * for UEFI. + */ static uint8_t rgb_to_color_index(uint8_t r, uint8_t g, uint8_t b) { @@ -321,8 +327,10 @@ rgb_to_color_index(uint8_t r, uint8_t g, uint8_t b) diff = b - pe8[k].Blue; dist += diff * diff; + /* Exact match, exit the loop */ if (dist == 0) break; + if (dist < best) { color = k; best = dist;