From owner-svn-src-all@FreeBSD.ORG  Tue May 19 09:11:22 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 99C8AC7D;
 Tue, 19 May 2015 09:11:22 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 243AE1624;
 Tue, 19 May 2015 09:11:21 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t4J9BIMx035396
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 19 May 2015 12:11:18 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t4J9BIfS035395;
 Tue, 19 May 2015 12:11:18 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 19 May 2015 12:11:18 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andrew Rybchenko <arybchik@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r282941 - head/sys/dev/sfxge
Message-ID: <20150519091118.GU15393@FreeBSD.org>
References: <201505150649.t4F6niTp042894@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201505150649.t4F6niTp042894@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 09:11:22 -0000

  Andrew,

On Fri, May 15, 2015 at 06:49:44AM +0000, Andrew Rybchenko wrote:
A> Author: arybchik
A> Date: Fri May 15 06:49:43 2015
A> New Revision: 282941
A> URL: https://svnweb.freebsd.org/changeset/base/282941
A> 
A> Log:
A>   sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed
A>   
A>   It is simply not required since the kernel checks corresponding
A>   IFCAP_TSOx capability and CSUM_TSO in hw-assisted offloads.
A>   Note that CSUM_TSO is two bits (CSUM_IP_TSO|CSUM_IP6_TSO) and both bits
A>   are set in IPv4 and IPv6 mbufs.

I am not sure that this is a part of driver KPI. AFAIU, the if_capenable
is user visible declaration of capabilities, and if_hwassist is stack
visible. So, they should be changed together. At least all drivers do that.
What made you to make such change to sfxge?

Whether this is a good KPI or not is of course discussable. If you have
ideas and improvements, let's do them in projects/ifnet branch.

-- 
Totus tuus, Glebius.