From owner-freebsd-current@freebsd.org Thu Jan 19 08:49:31 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3EF9CB71F1 for ; Thu, 19 Jan 2017 08:49:31 +0000 (UTC) (envelope-from jakob@alvermark.net) Received: from smtprelay-h31.telenor.se (smtprelay-h31.telenor.se [213.150.131.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 75F4C1054; Thu, 19 Jan 2017 08:49:30 +0000 (UTC) (envelope-from jakob@alvermark.net) Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id 0A5D0C749; Thu, 19 Jan 2017 09:49:21 +0100 (CET) X-SENDER-IP: [85.229.94.62] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DkFgBmfIBYED5e5VVeGgEBAQECAQEBAQgBAQEBgz8BAQEBAR9ggQkHg0qKepEQD5cpKoV4AoIORBQBAgEBAQEBAQEGAQEBAQEBAjhFhGoBBSMPASMjEAsOCgICFBICAjkKFAaJGgEJr1qCJRWKKwEBAQEBBQEBAQEkgQuKLoQzZII4gl4Fm0QBgX6EYox7UYQ9iWiRPgGBMTYggVIKhHUcgWE9NQEBiWIBAQE X-IPAS-Result: A2DkFgBmfIBYED5e5VVeGgEBAQECAQEBAQgBAQEBgz8BAQEBAR9ggQkHg0qKepEQD5cpKoV4AoIORBQBAgEBAQEBAQEGAQEBAQEBAjhFhGoBBSMPASMjEAsOCgICFBICAjkKFAaJGgEJr1qCJRWKKwEBAQEBBQEBAQEkgQuKLoQzZII4gl4Fm0QBgX6EYox7UYQ9iWiRPgGBMTYggVIKhHUcgWE9NQEBiWIBAQE X-IronPort-AV: E=Sophos;i="5.33,253,1477954800"; d="scan'208";a="652953700" Received: from c-3e5ee555.06-11-73746f31.cust.bredbandsbolaget.se (HELO sigyn.alvermark.net) ([85.229.94.62]) by ipb4.telenor.se with ESMTP; 19 Jan 2017 09:49:21 +0100 Received: from localhost ([127.0.0.1] helo=webmail.alvermark.net) by sigyn.alvermark.net with esmtp (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1cU8PG-0003EM-N4; Thu, 19 Jan 2017 09:49:18 +0100 Received: from 193.12.143.142 (SquirrelMail authenticated user alvis) by webmail.alvermark.net with HTTP; Thu, 19 Jan 2017 09:49:18 +0100 (CET) Message-ID: <63740.193.12.143.142.1484815758.squirrel@webmail.alvermark.net> In-Reply-To: <3516356.ILt4XdM4E4@ralph.baldwin.cx> References: <57236.193.12.143.142.1484240708.squirrel@webmail.alvermark.net> <64999.85.229.93.187.1484344018.squirrel@webmail.alvermark.net> <59599.193.12.143.142.1484657191.squirrel@webmail.alvermark.net> <3516356.ILt4XdM4E4@ralph.baldwin.cx> Date: Thu, 19 Jan 2017 09:49:18 +0100 (CET) Subject: Re: r311568 makes freerdp very slow From: "Jakob Alvermark" To: "John Baldwin" Cc: "Jakob Alvermark" , freebsd-current@freebsd.org, "Shawn Webb" User-Agent: SquirrelMail/1.5.1 MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 08:49:32 -0000 On Wed, January 18, 2017 19:29, John Baldwin wrote: > On Tuesday, January 17, 2017 01:46:31 PM Jakob Alvermark wrote: > >> On Fri, January 13, 2017 22:46, Jakob Alvermark wrote: >> >>> On Fri, January 13, 2017 19:44, John Baldwin wrote: >>> >>> >>>> On Friday, January 13, 2017 09:58:01 AM Jakob Alvermark wrote: >>>> >>>> >>>> >>>>> On Thu, January 12, 2017 19:26, John Baldwin wrote: >>>>> >>>>> >>>>> >>>>>> On Thursday, January 12, 2017 12:42:11 PM Shawn Webb wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> On Thu, Jan 12, 2017 at 06:05:08PM +0100, Jakob Alvermark >>>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> r311568 Set MORETOCOME for AIO write requests on a socket. >>>>>>>> >>>>>>>> After this commit freerdp is very slow. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Before the password prompt would appear immediately when >>>>>>>> connecting to a server. Now it takes 5-10 seconds. After >>>>>>>> entering the password, another 5-10 seconds until I am >>>>>>>> connected. Once connected, there is a considerable lag. >>>>>>>> >>>>>>>> >>>>>>>> What could be the problem? >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> I don't know what the problem is, but I am seeing the same >>>>>>> symptom. >>>>>>> >>>>>>> >>>>>> >>>>>> Can you get a ktrace of the freerdp process during this? The >>>>>> commit should only be setting MORETOCOME if multiple aio_write >>>>>> requests are queued to the same socket (so that TCP can batch >>>>>> them into a single packet). However, it should not affect an >>>>>> application just calling aio_write() on a socket once. >>>>>> >>>>>> -- >>>>>> John Baldwin >>>>>> >>>>>> >>>>>> >>>>> >>>>> Hi John, >>>>> >>>>> >>>>> >>>>> >>>>> I got the ktrace, what do I do with it? >>>>> >>>>> >>>>> >>>> >>>> kdump will generate a text representation, perhaps using 'kdump -s' >>>> to not include dumps of raw I/O data. If you can put the output of >>>> kdump at a URL I can fetch from then I can look at it. >>>> >>> >>> OK, here it is: >>> http://filebin.ca/38mkuLau9Yqu/ktrace.out.xfreerdp.txt >>> >>> >>> >>> Thanks, >>> >>> >>> >>> Jakob >>> >> >> Hi, >> >> >> Did you get any chance to look at this? >> > > I have not yet, but can you please try the fix in r312387? > > > -- > John Baldwin > > Yes, I am now at r312404 and it works as before again. Thanks! Jakob