Date: Thu, 19 Jan 2017 09:49:18 +0100 (CET) From: "Jakob Alvermark" <jakob@alvermark.net> To: "John Baldwin" <jhb@freebsd.org> Cc: "Jakob Alvermark" <jakob@alvermark.net>, freebsd-current@freebsd.org, "Shawn Webb" <shawn.webb@hardenedbsd.org> Subject: Re: r311568 makes freerdp very slow Message-ID: <63740.193.12.143.142.1484815758.squirrel@webmail.alvermark.net> In-Reply-To: <3516356.ILt4XdM4E4@ralph.baldwin.cx> References: <57236.193.12.143.142.1484240708.squirrel@webmail.alvermark.net> <64999.85.229.93.187.1484344018.squirrel@webmail.alvermark.net> <59599.193.12.143.142.1484657191.squirrel@webmail.alvermark.net> <3516356.ILt4XdM4E4@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, January 18, 2017 19:29, John Baldwin wrote: > On Tuesday, January 17, 2017 01:46:31 PM Jakob Alvermark wrote: > >> On Fri, January 13, 2017 22:46, Jakob Alvermark wrote: >> >>> On Fri, January 13, 2017 19:44, John Baldwin wrote: >>> >>> >>>> On Friday, January 13, 2017 09:58:01 AM Jakob Alvermark wrote: >>>> >>>> >>>> >>>>> On Thu, January 12, 2017 19:26, John Baldwin wrote: >>>>> >>>>> >>>>> >>>>>> On Thursday, January 12, 2017 12:42:11 PM Shawn Webb wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> On Thu, Jan 12, 2017 at 06:05:08PM +0100, Jakob Alvermark >>>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> r311568 Set MORETOCOME for AIO write requests on a socket. >>>>>>>> >>>>>>>> After this commit freerdp is very slow. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Before the password prompt would appear immediately when >>>>>>>> connecting to a server. Now it takes 5-10 seconds. After >>>>>>>> entering the password, another 5-10 seconds until I am >>>>>>>> connected. Once connected, there is a considerable lag. >>>>>>>> >>>>>>>> >>>>>>>> What could be the problem? >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> I don't know what the problem is, but I am seeing the same >>>>>>> symptom. >>>>>>> >>>>>>> >>>>>> >>>>>> Can you get a ktrace of the freerdp process during this? The >>>>>> commit should only be setting MORETOCOME if multiple aio_write >>>>>> requests are queued to the same socket (so that TCP can batch >>>>>> them into a single packet). However, it should not affect an >>>>>> application just calling aio_write() on a socket once. >>>>>> >>>>>> -- >>>>>> John Baldwin >>>>>> >>>>>> >>>>>> >>>>> >>>>> Hi John, >>>>> >>>>> >>>>> >>>>> >>>>> I got the ktrace, what do I do with it? >>>>> >>>>> >>>>> >>>> >>>> kdump will generate a text representation, perhaps using 'kdump -s' >>>> to not include dumps of raw I/O data. If you can put the output of >>>> kdump at a URL I can fetch from then I can look at it. >>>> >>> >>> OK, here it is: >>> http://filebin.ca/38mkuLau9Yqu/ktrace.out.xfreerdp.txt >>> >>> >>> >>> Thanks, >>> >>> >>> >>> Jakob >>> >> >> Hi, >> >> >> Did you get any chance to look at this? >> > > I have not yet, but can you please try the fix in r312387? > > > -- > John Baldwin > > Yes, I am now at r312404 and it works as before again. Thanks! Jakob
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?63740.193.12.143.142.1484815758.squirrel>