From owner-freebsd-x11@freebsd.org  Tue Feb  4 12:34:01 2020
Return-Path: <owner-freebsd-x11@freebsd.org>
Delivered-To: freebsd-x11@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63BA12454EA
 for <freebsd-x11@mailman.nyi.freebsd.org>;
 Tue,  4 Feb 2020 12:34:01 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48Bkdj1lJJz3Mp5;
 Tue,  4 Feb 2020 12:34:01 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 157261CF63; Tue,  4 Feb 2020 12:34:01 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Hans Petter Selasky <hps@selasky.org>
Cc: freebsd-x11@FreeBSD.org
Subject: Re: X11 + i915kms
References: <abff058c-795c-ed85-65a6-ee2d440817a2@selasky.org>
 <d0ca-58eq-wny@FreeBSD.org>
 <a8e02116-6f8c-947e-93a3-3d75411f9aec@selasky.org>
Date: Tue, 04 Feb 2020 13:33:58 +0100
In-Reply-To: <a8e02116-6f8c-947e-93a3-3d75411f9aec@selasky.org> (Hans Petter
 Selasky's message of "Mon, 3 Feb 2020 12:01:49 +0100")
Message-ID: <a75y-ttu1-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11/>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2020 12:34:01 -0000

Hans Petter Selasky <hps@selasky.org> writes:

> On 2019-12-27 12:12, Jan Beich wrote:
>
>> Hans Petter Selasky <hps@selasky.org> writes:
>> 
>>> Hi,
>>>
>>> Just did a fresh install of X11 and stuff. I noticed the
>>> xf86-video-intel is very sluggish unless SNA acceleration mode is
>>> selected. Do you know anything about this? Maybe make it the default?
>>> Or should I have used another driver?
>> FreeBSD disabled SNA by default for compatibility with
>> pre-SandyBridge
>> on drm-legacy-kmod (previously, in-base drm2), see bug 214593.
>> SNA is also unstable due to I915_USERPTR_UNSYNCHRONIZED, so you may
>> need the patch in bug 236003.
>
> Does this fix the issue?
> https://github.com/FreeBSDDesktop/kms-drm/pull/205

Yes but it needs to be applied to drm-v4.11 and drm-v4.16 as well.
drm-v4.9 works fine as is. I've originally reported the issue
in https://github.com/FreeBSDDesktop/kms-drm/issues/32.

However, the way you've handled LinuxKPI changes won't help on already
released FreeBSD versions e.g.,

graphics/drm-fbsd12.0-kmod on FreeBSD 12.1:
  drivers/gpu/drm/i915/i915_gem_userptr.c:514:7: error: implicit declaration of function 'mmget_not_zero' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                  if (mmget_not_zero(mm)) {
                      ^
  drivers/gpu/drm/i915/i915_gem_userptr.c:514:7: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]

graphics/drm-fbsd11.2-kmod on FreeBSD 11.3:
  i915_gem_userptr.c:511:7: error: implicit declaration of function 'mmget_not_zero' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                  if (mmget_not_zero(mm)) {
                      ^
  i915_gem_userptr.c:511:7: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]