From owner-svn-src-all@freebsd.org Tue Jul 26 17:03:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 140E8BA58EA; Tue, 26 Jul 2016 17:03:22 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1B0A145B; Tue, 26 Jul 2016 17:03:21 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x230.google.com with SMTP id b62so30638118iod.3; Tue, 26 Jul 2016 10:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QM4KblAYYqx1k+G3FW/oEc1yX44N71IvM7pbxnQFUaU=; b=n3ahKjl2fMpWGLp+i6g+ql+5caRHsDo7fH2J2I9xJMTGCqOA7pP/J/VUj2XIfJ2X7z o+oLfCgoL1AiBJ7WOovtanCDSxPiFNnLAJfPI1XoHeRqFJjjeFFsyxxfz0+9QVBnV5Yc wM/IdFw1CVi6qWrrOGKzG3Cli1xrxRXonnTnO+F9gAk8RAS7w5Ihc0VYV2gpNsGFnB9q p8ybg2WQh3Qt2oQ2wKhV9zzK8aYDUbJT1hYjn20gvoUGHkNgIUIoKIpTfdURr5TKsA8f drT+tAzHosgFxdycTEcZwXmLAYAWJGtv2oDZNXwn8sAcC8bpzBhMbf78HESOl6TMOtek tsfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QM4KblAYYqx1k+G3FW/oEc1yX44N71IvM7pbxnQFUaU=; b=WQWuq7A/NA8pCk9NPvA/ym+cfklgIV2QqUMevnNoveZL/g5AfGDPUyW72rg1ee6Tt/ sTfsvXIZu3irWmTBiTkrJzvftbso/HDHGnoywE5tXKnSlRU+3RGNvNvUvUXz8Cz2TwzC K1mRb0WLImtXXJ7S0W6qHQrNOPHvo9rah6+qqhySjYQObJXUtJWHFSpnLV8VCNIkkxy3 lrfPf7UKtG+szPmS2GOS0X0DHj/8Rgjc4QQcot4zmQP9v1K4xyelCOFFhZX12T+QcPpn UQ2oMh2dExpldBkyIZxWqKEan6K5yJ+VV/AfMBQIAjjvD/p9Blt4UAZvgoGReoG5g7YB y1FQ== X-Gm-Message-State: AEkoouufwP4aapIoDoN4iNc3pHqGInc+AF+RAxnWUOK0/Vwit/jIFr3eCEvhBY//cY4QpxdKTIRfV4FCw9eKiw== X-Received: by 10.107.141.213 with SMTP id p204mr26248294iod.38.1469552601270; Tue, 26 Jul 2016 10:03:21 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.138.28 with HTTP; Tue, 26 Jul 2016 10:03:01 -0700 (PDT) In-Reply-To: References: <201607261534.u6QFYQ9L017045@repo.freebsd.org> From: Ed Maste Date: Tue, 26 Jul 2016 13:03:01 -0400 X-Google-Sender-Auth: RhxQS8URF5hFBuO8NxiF_1cZQMs Message-ID: Subject: Re: svn commit: r303338 - head/sys/dev/vt To: Ed Schouten Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 17:03:22 -0000 On 26 July 2016 at 12:27, Ed Schouten wrote: > Hi Ed, > > 2016-07-26 17:34 GMT+02:00 Ed Maste : >> if (vw == vd->vd_curwindow) { >> + mtx_lock(&Giant); >> kbd = kbd_get_keyboard(vd->vd_keyboard); >> if (kbd != NULL) >> vt_save_kbd_state(vw, kbd); >> + mtx_unlock(&Giant); >> } > > Would it make sense to put an mtx_assert(&Giant, MA_OWNED) in > kbd_get_keyboard()? Yes, I made that change locally and also intend to review kbd_get_keyboard's callers. I didn't commit it to HEAD right away to avoid mass breakage if there's missing locking.