From owner-freebsd-mips@FreeBSD.ORG Wed Feb 19 20:37:04 2014 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 03DE07DE for ; Wed, 19 Feb 2014 20:37:04 +0000 (UTC) Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com [209.85.223.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BCD1411AA for ; Wed, 19 Feb 2014 20:37:03 +0000 (UTC) Received: by mail-ie0-f171.google.com with SMTP id to1so642015ieb.16 for ; Wed, 19 Feb 2014 12:36:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=EmEu5tnITDxdRwas+R847iGfz1N4bZeiSV70FuU8sZo=; b=cqbcNuWqNcgAioNYKEzIucmYQZMjrAj/ZlUeKUczDsuCicTH6Rg/1U07b+VvaOizcq 0CaqTsqDgj9lu9T72snzlwdFVA3jvyOTxyyjLIUBN9PuMx5yi/LPTS4Vovb2GOPAuawC S3hVlFbTMsyFV3D3/4jNjuxA5RxjhE2YII2iUFNotwoB8xnE2hqOM8IhCOXNCOqt49Mn rEd8q7NHhcv4lgNMGrh6ifzlJ2u0JuBwetQT6THAbCfK/+Sz256s27hNI8yQul0U1sMv wfPpIh0573GPr1/j/2E96/diQhhWkJgv0MdFMvi+BA1b5SNjlW1y1hQMITE4ADlsQGFJ iReA== X-Gm-Message-State: ALoCoQlGHJFQZBglON2wWJk07Tg/ncQDsqg8sLNyyyWpQCwB/pcA/9H90rObgRIEEpDZ7TOXd/L5 X-Received: by 10.50.103.101 with SMTP id fv5mr3365870igb.2.1392842217573; Wed, 19 Feb 2014 12:36:57 -0800 (PST) Received: from macmini.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id iq9sm4174325igb.7.2014.02.19.12.36.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Feb 2014 12:36:56 -0800 (PST) Subject: Re: [RFC] Enable use of UserLocal Register (ULRI) if detected (patches) Mime-Version: 1.0 (Apple Message framework v1085) From: Warner Losh In-Reply-To: <7FA7DFD1-B1F1-400A-9107-8D8450B309A2@FreeBSD.org> Date: Wed, 19 Feb 2014 13:36:55 -0700 Message-Id: References: <092B0786-EA73-44D0-81FC-DFB56B14D4D7@bsdimp.com> <7FA7DFD1-B1F1-400A-9107-8D8450B309A2@FreeBSD.org> To: Stacey Son X-Mailer: Apple Mail (2.1085) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: "freebsd-mips@freebsd.org" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 20:37:04 -0000 On Feb 19, 2014, at 11:39 AM, Stacey Son wrote: >=20 > On Feb 19, 2014, at 11:52 AM, Warner Losh wrote: >=20 >> +/* Register numbers */ >> +#define _V0 2 >> +#define _A1 5 >> +#define _T0 12 >> +#define _RA 31 >>=20 >> We already have defines for these registers elsewhere. Any reason why = you chose not to use them? Also, is there any ABI difference to be = worried about? >=20 > Hmm... I missed these in sys/mips/include/regnum.h for some reason. = :) >=20 >> The rest looks generally good, apart from references to git versions = that might be difficult to find in the future. Consider moving details = inline instead. >=20 > That was really just a note to myself that I forgot to remove. >=20 > I have refreshed the patch with these changes: >=20 > http://people.freebsd.org/~sson/mips/ulri/ulri_kernel.diff Did you upload the right patch, since this seems to be using the new = #defines still.. >>> The final patch is for qemu system-mode that adds support for the = ULRI: >>>=20 >>> http://people.freebsd.org/~sson/mips/ulri/ulri_qemu.diff >>=20 >> Can't say about these... >=20 > Qemu, like a lot of MIPS hardware it seems, doesn't support the ULRI. = The above is a just quick hack to qemu to add support as a 'FYI'. I = should maybe clean it up and submit it to the qemu development list. OK. I'll have to give these patches a spin on my octeon boards. I'd had = a conversation with one if Cavium's engineers years ago where he said = that he wished FreeBSD implemented TLS this way, implying cavium has = them. But seeing the other note from Juli makes me unsure (since she = would know better than I)... Warner=