Date: Mon, 2 Feb 2015 13:24:11 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Dirk Meyer <dinoex@FreeBSD.org>, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>, ports-committers@FreeBSD.org Subject: Re: svn commit: r378229 - head/sysutils/xen-tools Message-ID: <20150202132411.GA90956@FreeBSD.org> In-Reply-To: <20150202130123.GJ11558@ivaldir.etoilebsd.net> References: <201502010704.t1174age082281@svn.freebsd.org> <20150201073353.GA81373@FreeBSD.org> <20150201115859.GA92369@enceladus10.kn-bremen.de> <20150202130123.GJ11558@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 02, 2015 at 02:01:23PM +0100, Baptiste Daroussin wrote:
> On Sun, Feb 01, 2015 at 12:58:59PM +0100, Juergen Lock wrote:
> > On Sun, Feb 01, 2015 at 07:33:53AM +0000, Alexey Dokuchaev wrote:
> > > But why? What's the reason behind this change?
> >
> > I guess he meant...
> >
> > > -BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash \
> > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl
> > > +BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash
> > > +LIB_DEPENDS= libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > > + ibyajl.so:${PORTSDIR}/devel/yajl
>
> Which would be wrong as well because xen-tools startically uses those
> dependencies.
>
> So it does not depend on any.so it depends on a .a, meaning the right fix
> here would be to use BUILD_DEPENDS= ${LOCALBASE}/libglib-2.0.a and not the
> .so
Thanks for clarification Baptiste, makes sense. Dirk, would you mind
revisiting your commit accordingly? Since we do not ship bash(1) in the
base, $localbase is also redundant in that bdep line.
Last but not least, I'd like to remind all of us about importance of giving
the rationale for your changes in commit logs. Simply enumerating changes
is not enough (and quite obvious from the diff per se).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150202132411.GA90956>