From owner-freebsd-current@FreeBSD.ORG Tue Sep 14 16:38:21 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F00D516A4D0; Tue, 14 Sep 2004 16:38:20 +0000 (GMT) Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E53643D48; Tue, 14 Sep 2004 16:38:19 +0000 (GMT) (envelope-from keramida@linux.gr) Received: from orion.daedalusnetworks.priv (host5.bedc.ondsl.gr [62.103.39.229])i8EGcG7K011695; Tue, 14 Sep 2004 19:38:16 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) i8EGcAA7002308; Tue, 14 Sep 2004 19:38:10 +0300 (EEST) (envelope-from keramida@linux.gr) Received: (from keramida@localhost)i8EGcAOe002307; Tue, 14 Sep 2004 19:38:10 +0300 (EEST) (envelope-from keramida@linux.gr) Date: Tue, 14 Sep 2004 19:38:10 +0300 From: Giorgos Keramidas To: Lukas Ertl Message-ID: <20040914163810.GA2240@orion.daedalusnetworks.priv> References: <20040914175102.R528@korben.in.tern> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040914175102.R528@korben.in.tern> cc: freebsd-current@freebsd.org Subject: Re: rcorder(8) dumps core X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2004 16:38:21 -0000 On 2004-09-14 17:52, Lukas Ertl wrote: > Hi, > today I noticed a problem with rcorder on a very recent -CURRENT: The core dump is triggered by the circular deps introduced by a recent s/ntpdate/ntpd/ in rc.d/rpcbind (see my reply to the commit message). >From a very quick first check it seems that circular dependencies somehow mess up the memory management of rcorder and it bombs while trying to free() the same pointer. The rest of the warnings printed by rcorder (missing or plainly wrong dependencies) can be fixed by this patch (which I haven't sent to freebsd-rc for review yet, but here it is): %%% Index: ike =================================================================== RCS file: /home/ncvs/src/etc/rc.d/ike,v retrieving revision 1.2 diff -u -r1.2 ike --- ike 8 Mar 2004 12:25:05 -0000 1.2 +++ ike 14 Sep 2004 10:10:15 -0000 @@ -4,7 +4,7 @@ # # PROVIDE: ike -# REQUIRE: root beforenetlkm mountcritlocal +# REQUIRE: root mountcritlocal # BEFORE: DAEMON # KEYWORD: FreeBSD nojail Index: nsswitch =================================================================== RCS file: /home/ncvs/src/etc/rc.d/nsswitch,v retrieving revision 1.3 diff -u -r1.3 nsswitch --- nsswitch 21 Jun 2004 19:38:58 -0000 1.3 +++ nsswitch 14 Sep 2004 10:09:46 -0000 @@ -28,7 +28,7 @@ # PROVIDE: nsswitch # REQUIRE: root -# BEFORE: network +# BEFORE: NETWORK # KEYWORD: FreeBSD . /etc/rc.subr Index: pf =================================================================== RCS file: /home/ncvs/src/etc/rc.d/pf,v retrieving revision 1.3 diff -u -r1.3 pf --- pf 23 Jun 2004 01:42:06 -0000 1.3 +++ pf 14 Sep 2004 10:08:31 -0000 @@ -4,7 +4,7 @@ # # PROVIDE: pf -# REQUIRE: root beforenetlkm mountcritlocal netif pflog +# REQUIRE: root mountcritlocal netif pflog # BEFORE: DAEMON LOGIN # KEYWORD: FreeBSD nojail Index: pflog =================================================================== RCS file: /home/ncvs/src/etc/rc.d/pflog,v retrieving revision 1.2 diff -u -r1.2 pflog --- pflog 31 Aug 2004 14:23:51 -0000 1.2 +++ pflog 14 Sep 2004 10:08:10 -0000 @@ -4,7 +4,7 @@ # # PROVIDE: pflog -# REQUIRE: root beforenetlkm mountcritlocal netif +# REQUIRE: root mountcritlocal netif # BEFORE: DAEMON LOGIN # KEYWORD: FreeBSD nojail %%%