From owner-freebsd-multimedia@FreeBSD.ORG Mon May 9 07:55:41 2005 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 282E616A4E7 for ; Mon, 9 May 2005 07:55:41 +0000 (GMT) Received: from rndsoft.co.kr (michelle.rndsoft.co.kr [211.32.202.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B78143D41 for ; Mon, 9 May 2005 07:55:40 +0000 (GMT) (envelope-from yongari@rndsoft.co.kr) Received: from yongari@rndsoft.co.kr(192.168.5.90) by MailFilter v1.05 with ESMTP Processed in 0.126769 secs; 09 May 2005 16:52:55 +0900 Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) j497sGkx002363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 9 May 2005 16:54:16 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j497sGKe002362 for freebsd-multimedia@freebsd.org; Mon, 9 May 2005 16:54:16 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Mon, 9 May 2005 16:54:16 +0900 From: Pyun YongHyeon To: freebsd-multimedia@freebsd.org Message-ID: <20050509075416.GD915@rndsoft.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Subject: maestro3 mpsafe patch X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: yongari@rndsoft.co.kr List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2005 07:55:41 -0000 Here is patch for mpsafe maestro3(4). There is one known LOR in module unload. But the LOR complaint message is misleading since it's not legal to grab sx lock while holding mutex. I think the fix would be hard without cleaning up many parts of audio subsystem. But the complaint would be harmless if sndstat is not accessed during module unload. The patch was tested on an old notebook. Becasue the notebook is UP machine I had no chance to run the patch on real SMP hardware. :( The patch is available at: http://people.freebsd.org/~yongari/maestro3.mpsafe.patch.0509 Feedbacks are welcome. -- Regards, Pyun YongHyeon http://www.kr.freebsd.org/~yongari | yongari@freebsd.org