From owner-cvs-src@FreeBSD.ORG Fri Jul 30 13:44:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 524D416A4CE; Fri, 30 Jul 2004 13:44:52 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F1A243D60; Fri, 30 Jul 2004 13:44:51 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i6UDhllR088790; Fri, 30 Jul 2004 07:43:47 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 30 Jul 2004 07:44:12 -0600 (MDT) Message-Id: <20040730.074412.85393432.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <4109853F.3090508@samsco.org> References: <41097469.10807@samsco.org> <20040729222415.GA728@VARK.homeunix.com> <4109853F.3090508@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/src e_scalb.c e_scalbf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2004 13:44:52 -0000 In message: <4109853F.3090508@samsco.org> Scott Long writes: : David Schultz wrote: : > On Thu, Jul 29, 2004, Scott Long wrote: : > : >>David Schultz wrote: : >> : >>>das 2004-07-09 10:01:10 UTC : >>> : >>> FreeBSD src repository : >>> : >>> Modified files: : >>> lib/msun/src e_scalb.c e_scalbf.c : >>> Log: : >>> Remove the declaration of isnan() from this file. It is no longer : >>> needed as of math.h v1.40, and its prototype is incorrect here. : >>> : >>> Revision Changes Path : >>> 1.11 +0 -3 src/lib/msun/src/e_scalb.c : >>> 1.9 +0 -3 src/lib/msun/src/e_scalbf.c : >> : >>I think that this might be related to the snapshot server not being able : >>to build a 5-CURRENT snapshot since about this date. Can you look at : >>the following? : >> : >>ftp://snapshots.jp.freebsd.org/pub/FreeBSD/snapshots/i386/5.2-CURRENT-20040729-JPSNAP.log : > : > : > I'll take a look tonight if I have time. (The problem is actually : > with the introduction of fdiml() to libm, which uses isnan() from : > libc, but still my fault.) This error should only occur if your : > libc is older than your libm and your program is using fdiml(), : > though... : : Is this going to hose people doing source upgrades from 5.2.1 to 5.3 : and/or 4.x to 5.3. I know that the latter is going to be tough for a : lot of other reasons, but loosing the former would be bad. Also, does : it affect binary compat of 4.x/5.2 programs on 5.3? Long before we get to libm issues, we have issues building on 4.10: cc -O -pipe -DIN_GCC -DHAVE_CONFIG_H -DPREFIX=\"/u/misc/imp/obj/home/imp/FreeBSD/src/i386/usr\" -I/u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_tools -I/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_tools -I/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../../../../contrib/gcc -I/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../../../../contrib/gcc/config -I. -I/u/misc/imp/obj/home/imp/FreeBSD/src/i386/legacy/usr/include -static -L/u/misc/imp/obj/home/imp/FreeBSD/src/i386/legacy/usr/lib -o cc1 main.o c-parse+%DIKED.o c-lang.o stub-objc.o /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a -legacy /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o): In function `fancy_abort': diagnostic.o(.text+0x81c): multiple definition of `fancy_abort' /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(errors.o)(.text+0x194): first defined here /usr/libexec/elf/ld: Warning: size of symbol `fancy_abort' changed from 25 to 39 in /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o) /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o): In function `trim_filename': diagnostic.o(.text+0x4f8): multiple definition of `trim_filename' /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(errors.o)(.text+0x158): first defined here /usr/libexec/elf/ld: Warning: size of symbol `trim_filename' changed from 58 to 94 in /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o) /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o): In function `warning': diagnostic.o(.text+0x5ec): multiple definition of `warning' /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(errors.o)(.text+0x0): first defined here /usr/libexec/elf/ld: Warning: size of symbol `warning' changed from 81 to 72 in /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o) /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o): In function `error': diagnostic.o(.text+0x68c): multiple definition of `error' /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(errors.o)(.text+0x54): first defined here /usr/libexec/elf/ld: Warning: size of symbol `error' changed from 91 to 72 in /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o) /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o): In function `internal_error': diagnostic.o(.text+0x764): multiple definition of `internal_error' /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(errors.o)(.text+0x104): first defined here /usr/libexec/elf/ld: Warning: size of symbol `internal_error' changed from 84 to 72 in /u/misc/imp/obj/home/imp/FreeBSD/src/i386/home/imp/FreeBSD/src/gnu/usr.bin/cc/cc1/../cc_int/libcc_int.a(diagnostic.o) *** Error code 1 I don't know if the e_scalbf.c chanages cause problems down stream, but this was built on: FreeBSD harmony.village.org 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #18: Tue May 18 08:55:28 MDT 2004 imp@harmony.village.org:/home/imp/FreeBSD/4x/src/sys/compile/HARMONY i386 which is fairly close 4.10 release. Warner