From owner-freebsd-ports-bugs@freebsd.org Tue Sep 17 18:58:37 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E6E312BFB2 for ; Tue, 17 Sep 2019 18:58:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Xsp51rjhz4YYg for ; Tue, 17 Sep 2019 18:58:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3DA9212BFB1; Tue, 17 Sep 2019 18:58:37 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D6FE12BFB0 for ; Tue, 17 Sep 2019 18:58:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xsp50mptz4YYf for ; Tue, 17 Sep 2019 18:58:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DA18419244 for ; Tue, 17 Sep 2019 18:58:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HIwacT090338 for ; Tue, 17 Sep 2019 18:58:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HIwaTa090337 for ports-bugs@FreeBSD.org; Tue, 17 Sep 2019 18:58:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240649] audio/murmur: Fix broken murmur.ini defaults (patch) Date: Tue, 17 Sep 2019 18:58:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jacob@dstsrc.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: feld@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:58:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240649 Bug ID: 240649 Summary: audio/murmur: Fix broken murmur.ini defaults (patch) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: feld@FreeBSD.org Reporter: jacob@dstsrc.net Flags: maintainer-feedback?(feld@FreeBSD.org) Assignee: feld@FreeBSD.org Created attachment 207579 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207579&action= =3Dedit Fixes issue with ini values The sed snippets to set reasonable defaults for pidfile, logfile, and host = are incorrectly expecting comments to start with "#" instead of ";". I suspect = this is caused by a change upstream, but I haven't verified this. The issue is f= ixed by the first patch. The second patch contains a few changes to make the port more in line with recommendations in the Porter's Handbook. The required directories are not created by the rc script, instead they are handled by the Makefile and pkg-plist. The changes to murmur.ini are moved to the post-patch stage which seems more appropriate. Finally, the third patch simply removes the patching of host in murmur.ini.= As the comment in the file states, the equivalent of host=3D0.0.0.0 is already default. --=20 You are receiving this mail because: You are the assignee for the bug.=