From owner-freebsd-perl@FreeBSD.ORG Mon Jul 30 20:14:16 2007 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57B4416A419 for ; Mon, 30 Jul 2007 20:14:16 +0000 (UTC) (envelope-from jp@centtech.com) Received: from mh1.centtech.com (moat3.centtech.com [64.129.166.50]) by mx1.freebsd.org (Postfix) with ESMTP id B546013C465 for ; Mon, 30 Jul 2007 20:14:15 +0000 (UTC) (envelope-from jp@centtech.com) Received: from whiplash.centtech.com (jp@whiplash.centtech.com [10.20.200.99]) by mh1.centtech.com (8.13.8/8.13.8) with ESMTP id l6TJvnLi009880; Sun, 29 Jul 2007 14:57:49 -0500 (CDT) (envelope-from jp@centtech.com) Date: Sun, 29 Jul 2007 14:57:49 -0500 (CDT) From: "Jonathan C. Patschke" To: perl@freebsd.org Message-ID: <20070729140719.I6621@whiplash.centtech.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-212006205-1185739069=:6621" X-Virus-Scanned: ClamAV 0.88.4/3806/Sun Jul 29 13:19:59 2007 on mh1.centtech.com X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=8.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.6 X-Spam-Checker-Version: SpamAssassin 3.1.6 (2006-10-03) on mh1.centtech.com X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: matt@sergeant.org Subject: Patch for p5-DBD-SQLite X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2007 20:14:16 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-212006205-1185739069=:6621 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Below is an additional patch file for the databases/p5-DBD-SQLite port that should live in files/patch-dbdimp.c. It corrects the problem that positional parameters do not always work. Specifically, the problem is that, under certain conditions, when you prepare a statement with placeholders and specify a column order in the statement other than the one with which the table was created, the execute will die with 'Unknown named parameter'. I can't seem to find the smallest test case that makes the bug happen, but it did affect some of the queries I had in a largish program. I also found out that the Debian folks had also run into this problem, and their patch corrects the defect on FreeBSD. The patch begins here: --- dbdimp.c.orig Sun Jul 29 14:00:46 2007 +++ dbdimp.c Sun Jul 29 13:59:56 2007 @@ -440,7 +440,7 @@ int is_inout, IV maxlen) { int pos; - if (!SvIOK(param)) { + if (!SvIOKp(param)) { int len; char *paramstring; paramstring = SvPV(param, len); -- Jonathan C. Patschke Manufacturing Software Support Centaur Technology --0-212006205-1185739069=:6621--