From owner-freebsd-hackers Thu Aug 26 18:46:22 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 2AC1D14C39 for ; Thu, 26 Aug 1999 18:46:17 -0700 (PDT) (envelope-from ben@scientia.demon.co.uk) Received: from lithium.scientia.demon.co.uk ([192.168.0.3] ident=exim) by scientia.demon.co.uk with esmtp (Exim 3.032 #1) id 11K9CA-0000CN-00; Fri, 27 Aug 1999 00:44:38 +0100 Received: (from ben) by lithium.scientia.demon.co.uk (Exim 3.032 #1) id 11K9C9-00017K-00; Fri, 27 Aug 1999 00:44:37 +0100 Date: Fri, 27 Aug 1999 00:44:37 +0100 From: Ben Smithurst To: "Mark J. Taylor" Cc: hackers@freebsd.org Subject: Re: Request for review: vnconfig.c Message-ID: <19990827004437.B3921@lithium.scientia.demon.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.6i In-Reply-To: Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Mark J. Taylor wrote: > + dev = malloc(strlen(vnp->dev)+6); > + (void)sprintf(dev, "/dev/%s", vnp->dev); You should be checking that malloc() doesn't return NULL, before trying to write into the allocated space. -- Ben Smithurst | PGP: 0x99392F7D ben@scientia.demon.co.uk | key available from keyservers and | ben+pgp@scientia.demon.co.uk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message