From owner-freebsd-current@FreeBSD.ORG  Tue Oct 26 17:13:33 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 833B716A4CE
	for <freebsd-current@freebsd.org>;
	Tue, 26 Oct 2004 17:13:33 +0000 (GMT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BDED643D1D
	for <freebsd-current@freebsd.org>;
	Tue, 26 Oct 2004 17:13:32 +0000 (GMT)	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id DA26C65292; Tue, 26 Oct 2004 18:13:30 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 57388-01-3; Tue, 26 Oct 2004 18:13:30 +0100 (BST)
Received: from empiric.dek.spc.org (c-24-7-102-181.client.comcast.net
	[24.7.102.181])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id E619C65219; Tue, 26 Oct 2004 18:13:29 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 8A1636282; Tue, 26 Oct 2004 10:13:16 -0700 (PDT)
Date: Tue, 26 Oct 2004 10:13:16 -0700
From: Bruce M Simpson <bms@spc.org>
To: Sam <sah@softcardsystems.com>
Message-ID: <20041026171316.GA697@empiric.icir.org>
Mail-Followup-To: Sam <sah@softcardsystems.com>,
	freebsd-current@freebsd.org
References: <Pine.LNX.4.60.0410261249330.4856@athena>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.60.0410261249330.4856@athena>
cc: freebsd-current@freebsd.org
Subject: Re: taskqueue(9) funny
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Oct 2004 17:13:33 -0000


--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 26, 2004 at 12:57:43PM -0500, Sam wrote:
> There is no task_fn type defined by taskqueue.h or _task.h.
> >From a documentation perspective this is ever-so-mildly
> deceiving.

This must mean task_fn_t. How about the attached patch?

BMS

P.S. Love the way mail user agents still escape lines beginning with
'From' even in 2004 because of good old mbox mail format.

--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="taskqueue.9.diff"

Index: taskqueue.9
===================================================================
RCS file: /home/ncvs/src/share/man/man9/taskqueue.9,v
retrieving revision 1.12
diff -u -p -r1.12 taskqueue.9
--- taskqueue.9	8 Aug 2004 02:37:22 -0000	1.12
+++ taskqueue.9	26 Oct 2004 17:12:56 -0000
@@ -41,7 +41,7 @@
 .In sys/queue.h
 .In sys/taskqueue.h
 .Bd -literal
-typedef void (*task_fn)(void *context, int pending);
+typedef void (*task_fn_t)(void *context, int pending);
 
 typedef void (*taskqueue_enqueue_fn)(void *context);
 
@@ -49,7 +49,7 @@ struct task {
 	STAILQ_ENTRY(task)	ta_link;	/* link for queue */
 	int			ta_pending;	/* count times queued */
 	int			ta_priority;	/* priority of task in queue */
-	task_fn			ta_func;	/* task handler */
+	task_fn_t		ta_func;	/* task handler */
 	void			*ta_context;	/* argument for handler */
 };
 .Ed

--bp/iNruPH9dso1Pn--