From owner-freebsd-smp@FreeBSD.ORG  Fri Aug 31 08:53:41 2007
Return-Path: <owner-freebsd-smp@FreeBSD.ORG>
Delivered-To: smp@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3C2F316A419;
	Fri, 31 Aug 2007 08:53:41 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D43713C4A3;
	Fri, 31 Aug 2007 08:53:40 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <46D7D711.80406@FreeBSD.org>
Date: Fri, 31 Aug 2007 10:53:37 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: Alfred Perlstein <alfred@freebsd.org>
References: <20070831071048.GF87451@elvis.mu.org>
In-Reply-To: <20070831071048.GF87451@elvis.mu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: attilio@freebsd.org, smp@freebsd.org
Subject: Re: request for review: backport of sx and rwlocks from 7.0 to
	6-stable
X-BeenThere: freebsd-smp@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD SMP implementation group <freebsd-smp.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-smp>,
	<mailto:freebsd-smp-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-smp>
List-Post: <mailto:freebsd-smp@freebsd.org>
List-Help: <mailto:freebsd-smp-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-smp>,
	<mailto:freebsd-smp-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Aug 2007 08:53:41 -0000

Alfred Perlstein wrote:
> Hi guys,
> 
> Some work here at work was approved for sharing with community so
> I'm posting it here in hope of a review.
> 
> We run some pretty good stress testing on our code, so I think it's
> pretty solid.
> 
> My only concern is that I've tried my best to preserve kernel source
> API, but not binary compat though a few simple #defines.
> 
> I can make binary compat, in albeit a somewhat confusing manner, but
> that will require some rototilling and weird renaming of calls to
> the sleepq and turnstile code.  In short, I'd rather not, but I will
> if you think it's something that should be done.
> 
> There's also a few placeholders for lock profiling which I will
> very likely be backporting shortly as well.
> 
> Patch is attached.
> 
> Comments/questions?

Hmm, I would be happy to see this but I think binary compatibility is 
actually important here since this is -stable and low-level primitives 
like sx are probably used all over the place in existing third party 
modules.

Kris