From owner-freebsd-current@FreeBSD.ORG  Tue May 27 22:15:03 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7C4B537B401
	for <current@freebsd.org>; Tue, 27 May 2003 22:15:03 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A328A43F85
	for <current@freebsd.org>; Tue, 27 May 2003 22:15:00 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h4S5ExkA059989
	for <current@freebsd.org>; Tue, 27 May 2003 23:14:59 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 27 May 2003 23:14:43 -0600 (MDT)
Message-Id: <20030527.231443.42771754.imp@bsdimp.com>
To: current@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200305280837.19418.alex.neyman@auriga.ru>
References: <1054095955.1429.52.camel@boxster>
	<3ED43A34.7020704@btc.adaptec.com>
	<200305280837.19418.alex.neyman@auriga.ru>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: Kernel module inconsistency was policy on GPL'd drivers?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2003 05:15:03 -0000

In message: <200305280837.19418.alex.neyman@auriga.ru>
            Alexey Neyman <alex.neyman@auriga.ru> writes:
: I'd rather see something like
: PORTS_KMODS=audio/aureal-kmod xxx/yyy
: knob in the /etc/make.conf

Funny, I had similar thoughts before seeing your patch.  Here's my
latest patch.  You could put it in /etc/make.conf, but that's really
the wrong place because you typically would want to tie it to a
specific kernel config.  However, there's nothing stopping you from
doing that if you want.  I'd do it as a makeoptions, ala
MODULES_OVERRIDE.

This version fixes two bugs: make clean (reported by alex!), and
propigationg of SYSDIR.  I suppose that I should replace /usr/ports
with something like PORTSDIR too, eh?

Warner

--- //depot/user/imp/freebsd-imp/sys/conf/kern.post.mk#10
+++ /paco/imp/p4/src/sys/conf/kern.post.mk
@@ -21,6 +21,19 @@
 	    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
 .endif
 .endfor
+# Handle out of tree ports
+.if defined(PORTS_MODULES)
+.if defined(SYSDIR)
+PORTSMODULESENV=SYSDIR=${SYSDIR}
+.endif
+.for target in all install clean
+${target}: ports-${target}
+ports-${target}:
+.for __i in ${PORTS_MODULES}
+	cd /usr/ports/${__i}; ${PORTSMODULESENV} ${MAKE} ${target}
+.endfor
+.endfor
+.endif
 
 .ORDER: kernel-install modules-install