Date: Wed, 5 Jun 2024 12:57:52 -0400 From: Justin Hibbits <jhibbits@FreeBSD.org> To: Ryan Libby <rlibby@gmail.com> Cc: Enji Cooper <yaneurabeya@gmail.com>, Wei Hu <whu@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: bec000c9c1ef - main - amd64: add a func pointer to tlb shootdown function Message-ID: <20240605125743.5b39005f@ralga.knownspace> In-Reply-To: <CAHgpiFwoHd6JEGijeKGQHp3q265=Vreh6id7fUc56Dt8SuRtqw@mail.gmail.com> References: <202406051238.455CcdGB050229@gitrepo.freebsd.org> <EFF41E75-E97A-4ED7-B439-839346C9951B@gmail.com> <CAHgpiFwoHd6JEGijeKGQHp3q265=Vreh6id7fUc56Dt8SuRtqw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 5 Jun 2024 09:51:55 -0700 Ryan Libby <rlibby@gmail.com> wrote: > On Wed, Jun 5, 2024 at 8:49=E2=80=AFAM Enji Cooper <yaneurabeya@gmail.com> > wrote: > > > > > > On Jun 5, 2024, at 5:38=E2=80=AFAM, Wei Hu <whu@FreeBSD.org> wrote: > > > > The branch main has been updated by whu: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3Dbec000c9c1ef409989685bb03ff05= 32907befb4a > > > > commit bec000c9c1ef409989685bb03ff0532907befb4a > > Author: Souradeep Chakrabarti <schakrabarti@microsoft.com> > > AuthorDate: 2024-06-05 12:25:05 +0000 > > Commit: Wei Hu <whu@FreeBSD.org> > > CommitDate: 2024-06-05 12:25:05 +0000 > > > > amd64: add a func pointer to tlb shootdown function > > > > Make the tlb shootdown function as a pointer. By default, it > > still points to the system function smp_targeted_tlb_shootdown(). > > It allows other implemenations to overwrite in the future. > > > > Reviewed by: kib > > Tested by: whu > > Authored-by: Souradeep Chakrabarti > > <schakrabarti@microsoft.com> Co-Authored-by: Erni Sri Satya Vennela > > <ernis@microsoft.com> MFC after: 1 week > > Sponsored by: Microsoft > > Differential Revision: https://reviews.freebsd.org/D45174 > > > > > > This broke the i386 build: > > https://ci.freebsd.org/job/FreeBSD-main-i386-build/28056/ Cheers, > > -Enji > > =20 >=20 > Should this be touching sys/vm/pmap.h at all? It seems wholly > focused on amd64. >=20 > Ryan Agreed, this should be done in sys/amd64/include/pmap.h . - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240605125743.5b39005f>