From owner-freebsd-current@FreeBSD.ORG  Fri Aug 28 06:05:45 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 33234106568B
	for <freebsd-current@freebsd.org>; Fri, 28 Aug 2009 06:05:45 +0000 (UTC)
	(envelope-from mandrews@fark.com)
Received: from magnum.bit0.com (magnum.bit0.com [207.246.88.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 9925690475
	for <freebsd-current@freebsd.org>; Thu, 27 Aug 2009 22:36:48 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by magnum.bit0.com (Postfix) with ESMTP id C79B9F7431;
	Thu, 27 Aug 2009 18:26:27 -0400 (EDT)
X-Virus-Scanned: amavisd-new at bit0.com
Received: from magnum.bit0.com ([127.0.0.1])
	by localhost (magnum.int.bit0.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oCiN1mLzaAX8; Thu, 27 Aug 2009 18:26:17 -0400 (EDT)
Received: from beast.int.bit0.com (beast.int.bit0.com [172.27.0.2])
	by magnum.bit0.com (Postfix) with ESMTP;
	Thu, 27 Aug 2009 18:26:17 -0400 (EDT)
Date: Thu, 27 Aug 2009 18:26:17 -0400 (EDT)
From: Mike Andrews <mandrews@fark.com>
X-X-Sender: mandrews@beast.int.bit0.com
To: "Li, Qing" <qing.li@bluecoat.com>
In-Reply-To: <B583FBF374231F4A89607B4D08578A43052773AF@bcs-mail03.internal.cacheflow.com>
Message-ID: <alpine.BSF.2.00.0908271825560.13445@beast.int.bit0.com>
References: <109727.111234.43119@localhost>
	<20090827181522.81970.qmail@mailgate.gta.com>
	<B583FBF374231F4A89607B4D08578A43052773AF@bcs-mail03.internal.cacheflow.com>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Mailman-Approved-At: Fri, 28 Aug 2009 11:32:44 +0000
Cc: freebsd-current@freebsd.org, Larry Baird <lab@gta.com>
Subject: RE: 8.0-BETA3 reproducible panic under load
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2009 06:05:45 -0000

On Thu, 27 Aug 2009, Li, Qing wrote:

>>
>> Not sure if this is what you hit or not.  I once saw something
> similar.
>> The call to LLE_FREE() in ip_output doesn't expect NULL.  Adding
>>    if (ro->ro_lle != NULL)
>> just before the call to LLE_FREE() may fix your crashes.
>>
>
> Actually, LLE_FREE() should not be called at all here because the
> "if (!nortfree)" block test applies to route entries that are not
> from the flow-table.  And if the route entry is not from the
> flow-table, then the rt_lle field is invalid.
>
> I will commit the fix.

I'll try commenting out the LLE_FREE() line while I wait for the 
commit/MFC, thanks :)