From owner-svn-src-head@freebsd.org Sat Apr 11 21:36:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 606B827C13D; Sat, 11 Apr 2020 21:36:03 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4907VC1qFhz48vQ; Sat, 11 Apr 2020 21:36:03 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f42.google.com with SMTP id g23so5388802otq.4; Sat, 11 Apr 2020 14:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=t1SjdzkJVOBSJ3s/H7n5P8GILnXw0KODv8RQ6TtRUPM=; b=KY8Fyj0UJXmlOGWwVBYyVV1/7/em4q++qa/fXH820tuxe4D985s3PvmVi4iprvCPbI ap0ymR03DPRxHAiq3J9cHNMMD/dVFQa4PNOnPSAyXxfLt+DaTKUXALDfEWe3Wy7jvpSr Vg6ViCfSt8DYpcd13K0RlSWbQ++N3xDDWiwwdonJSn8vwrif8auqRNlJsi8A+TeJW8yL pvmXusfs9+4cOWcH79cAICVg3MAHhccmD4bvJz62gmmOa3QwC665o0Jx4QVlgfN/Bdvi TrKQyQax414Zb9y5aR8u0kv+HQQpbOXuZGC/cLsvOIrDjbESYyg6cFTewNgYknRxHzLe s34g== X-Gm-Message-State: AGi0PuYrWRTKY2ZtqpRb4QFjCbUnItctwY85WwxDCiRyeoOB4koYW8Af RkQJi7SxDgXUkLvwiarnUHhte59e X-Google-Smtp-Source: APiQypKkl4/81azWLzJdYOhYYBY4E+KnccgoWrOrsV/0t3+0k5rKLO2AOTXjy49Q7GWOl9C/m8YQTA== X-Received: by 2002:a9d:5e0d:: with SMTP id d13mr9292889oti.162.1586640961977; Sat, 11 Apr 2020 14:36:01 -0700 (PDT) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id g1sm3318737otr.37.2020.04.11.14.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Apr 2020 14:36:01 -0700 (PDT) Received: by mail-ot1-f50.google.com with SMTP id a49so5342888otc.11; Sat, 11 Apr 2020 14:36:01 -0700 (PDT) X-Received: by 2002:a4a:848e:: with SMTP id n14mr6329543oog.44.1586640961487; Sat, 11 Apr 2020 14:36:01 -0700 (PDT) MIME-Version: 1.0 References: <202004112036.03BKatfm047227@repo.freebsd.org> In-Reply-To: <202004112036.03BKatfm047227@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 11 Apr 2020 14:35:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r359809 - head/sys/netinet To: Michael Tuexen Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4907VC1qFhz48vQ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 21:36:03 -0000 Hi Michael, On Sat, Apr 11, 2020 at 1:37 PM Michael Tuexen wrote: > > Author: tuexen > Date: Sat Apr 11 20:36:54 2020 > New Revision: 359809 > URL: https://svnweb.freebsd.org/changeset/base/359809 > > Log: > Zero out pointers for consistency. > > This was found by running syzkaller on an INVARIANTS kernel. For consistency? If syzkaller found something due to INVARIANTS sys/queue.h debugging trashing the pointer values, masking them by writing zeroes doesn't help. Generally, defeating the kernel's INVARIANTS system is not wise or useful. In this use, consider using 'TAILQ_CONCAT(&stcb->asoc.strmout[i].outqueue, &oldstream[i].outqueue, next)' instead of the loop construct. Conrad