From nobody Fri Oct 20 16:57:55 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBrPJ1lysz4y0J8 for ; Fri, 20 Oct 2023 16:57:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBrPJ0csNz3RBK for ; Fri, 20 Oct 2023 16:57:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697821076; a=rsa-sha256; cv=none; b=wFrXqL0NhBERCG2ApYmhbQSdw6b+agmYljJTwFzyoi9EqTmFZt82UHRzIjPc8EznjL3i9i i4wGq01P4qvjaYEC7uFUIa1XUBl+rM7MQ2y7fL2n+UD4is5UGWaPD691QEK+REewdtjTV0 nDyUhqdTAJyv+wp24ElLsw9/60dd+P6y/TYMAJNAeR1yrSydtqyNh4HCZ5IOOegscIXC1B Jx/eY3h3uBWK3Qek6UQ5lGCNcua+VRXc00Q0vTnW98m9PZxhbmyIbEyy7XKkr7YuWGPVoV sadkoL42J2Y806VrvEro6fl2ETDiSkSMCjtKTRBTUVkokw0gczzICUZ8UikskQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697821076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J1uN1VFCbjjg8RuhFi/cYEbE5GpC/L8S6vNuW7w+uXk=; b=Hf+KRcLxCmP41DiNM+fNc7hX9szPPZds5yTZ/mnky9nEMwjJSEWnZVg2vD0M5NA4A3SH4T HksypT22x1aUeGZMtEvU3nQlG5W8DQ1qOh1W9WFPorLVeVdu4naLJmxkmThE3D0X9rohTQ 3FgNFAok08xhMSBjhG1FGr9yw2IFVNwPw/MzA8e9xi4AzvTB2KzjSFuqv3aoO/eqAgzHXg O2/MB24N/PW1uEg2EI5Kc7Wtib++DWHMJNxEROJ0kEacelKavJ3uR3eymc9M0bmNHJ5bEG C3n8QAu++uTm9oiKAfXkeQl6pggWpSvsxRF/QwRuc7cLGkXcE2mwbHSfdCpP/A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBrPH6hL6zhBj for ; Fri, 20 Oct 2023 16:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39KGvtjK030344 for ; Fri, 20 Oct 2023 16:57:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39KGvtJO030343 for bugs@FreeBSD.org; Fri, 20 Oct 2023 16:57:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274614] Issues with retry loop in pfctl_do_ioctl() Date: Fri, 20 Oct 2023 16:57:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nreilly@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274614 Bug ID: 274614 Summary: Issues with retry loop in pfctl_do_ioctl() Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: nreilly@blackberry.com The retry loop in pfctl_do_ioctl() is problematic. "data" is allocated outside the loop vi nvlist_pack() and then freed inside= on the first time through. If ENOSPC is returned from the ioctl() then it goes= to the retry and will now attempt to memcpy() the previously freed data before freeing it again. There was a recent fix just before the retry loop https://cgit.freebsd.org/src/commit/lib/libpfctl/libpfctl.c?id=3D6422599e74= db4bb8b47cead46760d96601d8396a without that there are even more problems where the memcpy() of nvlen could= be greater than the malloc() of size. This fix means that simply moving the re= try label up above the nvlist_pack() will not work as that would then undo the increasing of size on the retry. --=20 You are receiving this mail because: You are the assignee for the bug.=