From owner-cvs-all Fri Dec 4 19:19:12 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA26603 for cvs-all-outgoing; Fri, 4 Dec 1998 19:19:12 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id TAA26576; Fri, 4 Dec 1998 19:19:06 -0800 (PST) (envelope-from imp@village.org) Received: from harmony [10.0.0.6] by rover.village.org with esmtp (Exim 1.71 #1) id 0zm8F2-0000ni-00; Fri, 4 Dec 1998 20:18:44 -0700 Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.1/8.8.3) with ESMTP id UAA45023; Fri, 4 Dec 1998 20:18:13 -0700 (MST) Message-Id: <199812050318.UAA45023@harmony.village.org> To: Mike Smith Subject: Re: Requiring make depend (was: cvs commit: src/sys/sys bus.h bus_private.h conf.h devicestat.h module.h src/sys/kern bus_if.m device_if.m kern_con) Cc: Greg Lehey , "Jordan K. Hubbard" , Steve Kargl , "Robert V. Baron" , wollman@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-reply-to: Your message of "Fri, 04 Dec 1998 18:09:15 PST." <199812050209.SAA01724@dingo.cdrom.com> References: <199812050209.SAA01724@dingo.cdrom.com> Date: Fri, 04 Dec 1998 20:18:13 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk : 'make depend' should be *mandatory*, as the alternative involves : duplicating dependancy information in the source and in the : configuration infrastructure. I don't understand why this is a problem. A simple fix to conf/files solves this problem nicely. I fail to see how it is any different at all than the vnode_if.[ch] that are generated files that have been handled nicely for years. Warner Index: conf/files =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/conf/files,v retrieving revision 1.177 diff -d -u -r1.177 files --- files 1998/12/04 18:01:22 1.177 +++ files 1998/12/05 03:16:16 @@ -13,15 +13,12 @@ no-obj no-implicit-rule before-depend \ clean "aic7xxx_seq.h aic7xxx_reg.h" \ dependency "$S/dev/aic7xxx/aic7xxx.{reg,seq} $S/cam/scsi/scsi_message.h aicasm" -kern/subr_rman.c standard -kern/subr_bus.c standard \ - dependency "device_if.h bus_if.h" device_if.o standard \ dependency "device_if.c" \ compile-with "${NORMAL_C}" \ no-implicit-rule local device_if.c standard \ - dependency "$S/kern/makedevops.pl $S/kern/device_if.m" \ + dependency "$S/kern/makedevops.pl $S/kern/device_if.m device_if.h bus_if.h" \ compile-with "perl5 $S/kern/makedevops.pl -c $S/kern/device_if.m" \ no-obj no-implicit-rule before-depend local \ clean "device_if.c" @@ -35,7 +32,7 @@ compile-with "${NORMAL_C}" \ no-implicit-rule local bus_if.c standard \ - dependency "$S/kern/makedevops.pl $S/kern/bus_if.m" \ + dependency "$S/kern/makedevops.pl $S/kern/bus_if.m device_if.h bus_if.h" \ compile-with "perl5 $S/kern/makedevops.pl -c $S/kern/bus_if.m" \ no-obj no-implicit-rule before-depend local \ clean "bus_if.c" @@ -44,6 +41,10 @@ compile-with "perl5 $S/kern/makedevops.pl -h $S/kern/bus_if.m" \ no-obj no-implicit-rule before-depend \ clean "bus_if.h" +kern/subr_rman.c standard \ + dependency "device_if.h bus_if.h" +kern/subr_bus.c standard \ + dependency "device_if.h bus_if.h" coda/coda_namecache.c optional vcoda coda/coda_fbsd.c optional vcoda coda/coda_psdev.c optional vcoda To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message