From owner-p4-projects@FreeBSD.ORG Wed Aug 5 19:13:43 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E4CEC1065677; Wed, 5 Aug 2009 19:13:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E1601065673 for ; Wed, 5 Aug 2009 19:13:42 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8BD608FC1C for ; Wed, 5 Aug 2009 19:13:42 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n75JDgLR089444 for ; Wed, 5 Aug 2009 19:13:42 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n75JDgeJ089442 for perforce@freebsd.org; Wed, 5 Aug 2009 19:13:42 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Wed, 5 Aug 2009 19:13:42 GMT Message-Id: <200908051913.n75JDgeJ089442@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 167045 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2009 19:13:44 -0000 http://perforce.freebsd.org/chv.cgi?CH=167045 Change 167045 by rwatson@rwatson_cinnamon on 2009/08/05 19:13:26 Comment for the syscall code. Affected files ... .. //depot/projects/soc2009/marinosi_appaudit/src/sys/security/audit/audit_syscalls.c#6 edit Differences ... ==== //depot/projects/soc2009/marinosi_appaudit/src/sys/security/audit/audit_syscalls.c#6 (text) ==== @@ -540,6 +540,15 @@ return (EINVAL); return (audit_send_trigger(udata.au_trigger)); + /* + * XXXRW: as_name use a userspace character array, not a kernel space + * string pointer. We need to copyinstr() to a kernel character + * array for the purposes of looking it up, etc. + * + * XXXRW: Possibly audit_slice_*() should be able to return errors-- + * for example, if there's a name collision on creating slices, or i + * a slice can't be found for removal. + */ case A_CREATESLICE: if (uap->length != sizeof(udata.au_slice)) return (EINVAL);