From nobody Wed May 27 15:30:10 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQYTZ5vR1z6fCJM for ; Wed, 27 May 2026 15:30:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQYTZ36Bvz3SmR for ; Wed, 27 May 2026 15:30:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779895810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wkbhoSYiVG7FBDpASfC8QQxjAKJiPqWc+3Elo7XKpos=; b=vftzmUWz3WlO8WQq44ReHfhss2YTMRyofbfSUatzcAwydB1Q6I/ffUYatuWzJeFw+BVVMO s7icFcEkV8/g4QUrmzwXZzRnbBv9cMuSwmcH2irNnPhHS1I5StvimqpWN/tjfJrRf7mj7n gMG6AWmVJBBk4rBn1lPySbxyWZYjESagDfPANcLIfzEohDkew3k9D7VJxtFan3OFuZzj2S Lz7SlVy0ZGutPCHDPdyyMVBQiE49wCyI+Y/4C9PDqrVu/c/6i+lgnbXmsOx+gvBChWXbCt R8ltkcP57uuq3E8oyMg+0Ri8qhbu9t4yUng5P61UJFvYGd/u6NdPewiwBESlUw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779895810; a=rsa-sha256; cv=none; b=JAqBUhLT+IIkqjtzcpUovns12CbQ/eGcRdOJUy+B/zrBZf7+9mIJmOA8h88RXs2Jx8RyIp Q9oRKFQ7Jhi5EbBv3nenWem4OBqBpi/Ur61bGDJKmHyVx3RBf0rNtz5/6+N/08Tn93ZNDT omK13C0k1mdvnGBj2s6ZidfWA8eA0mkjn30mSJI4FUyBvHC8giQ+/hfh97u1anebKXzveP SjA1NaoVnkCsGIueyS2CG7ptj3Lu+TvBgatbJdraOKpQEAT8yAeKKHhJLttAfNx0F+gIMM 1i2R7cl1UWWMSp43Piz+HQPZbrZGuSiGIevmio50gYgP16SeG6liOHF45DUb3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779895810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wkbhoSYiVG7FBDpASfC8QQxjAKJiPqWc+3Elo7XKpos=; b=iazxV0Ht3tGv6bq5KWXP/KPht19lotjWOPcc0bnZlvbxKOPpi2BYDnVAY4pU1zObbbZsd6 fCfGo66xf8kfNbNTfe6Fo5ZUIEKj3/W8UwKWzIWxna9VLJi9NdGidcTdRHE0/qM/l1UeXX 0tEfMUJ/XYlKDxDAsjjobmwQE6tEPJ2ZCAEIGRcpBhLc/Gv6wwo7JRgb3OnkZG+LOOcf+2 A0Tm/D6XwuuxKAIRfixgla0HXD2EAY5nZowGVSaRmsEn1aDFWWwwdR+BRL3vcJ2zsZKfM1 u82A+0mvFYIUHpVeHyB7CVYdAok91jg+hOF+YggPyZ/0S53n58d1hPiSvoO75w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQYTZ1mVbz14QH for ; Wed, 27 May 2026 15:30:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3000d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 15:30:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 88bc1d7325aa - main - sound: Retire EQ states List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 88bc1d7325aa97520f7a308d70a5fcb39acdc5d2 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 15:30:10 +0000 Message-Id: <6a170e02.3000d.7bf78db0@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=88bc1d7325aa97520f7a308d70a5fcb39acdc5d2 commit 88bc1d7325aa97520f7a308d70a5fcb39acdc5d2 Author: Christos Margiolis AuthorDate: 2026-04-17 15:23:38 +0000 Commit: Christos Margiolis CommitDate: 2026-05-27 15:27:11 +0000 sound: Retire EQ states The SD_F_EQ_ENABLED does the same thing, and is actually what we test against in order to create the EQ feeder. Sponsored by: The FreeBSD Foundation MFC after: 1 week Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/15 --- sys/dev/sound/pcm/channel.c | 3 --- sys/dev/sound/pcm/feeder.h | 3 --- sys/dev/sound/pcm/feeder_eq.c | 25 ++----------------------- 3 files changed, 2 insertions(+), 29 deletions(-) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index c97a3158dbd9..a0ee16a14386 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -2209,9 +2209,6 @@ chn_syncstate(struct pcm_channel *c) device_printf(c->dev, "EQ: Failed to set preamp -- %d\n", d->eqpreamp); - if (d->flags & SD_F_EQ_ENABLED && - FEEDER_SET(f, FEEDEQ_STATE, FEEDEQ_ENABLE) != 0) - device_printf(c->dev, "EQ: Failed to enable\n"); } } } diff --git a/sys/dev/sound/pcm/feeder.h b/sys/dev/sound/pcm/feeder.h index 10bfe9dca8f3..127b479cd7c9 100644 --- a/sys/dev/sound/pcm/feeder.h +++ b/sys/dev/sound/pcm/feeder.h @@ -119,9 +119,6 @@ enum { FEEDEQ_TREBLE, FEEDEQ_BASS, FEEDEQ_PREAMP, - FEEDEQ_STATE, - FEEDEQ_ENABLE, - FEEDEQ_UNKNOWN }; int feeder_eq_validrate(uint32_t); diff --git a/sys/dev/sound/pcm/feeder_eq.c b/sys/dev/sound/pcm/feeder_eq.c index 6fd7d7f2bfff..fdb786171d5a 100644 --- a/sys/dev/sound/pcm/feeder_eq.c +++ b/sys/dev/sound/pcm/feeder_eq.c @@ -122,7 +122,6 @@ struct feed_eq_info { uint32_t rate; uint32_t align; int32_t preamp; - int state; }; #if !defined(_KERNEL) && defined(FEEDEQ_ERR_CLIP) @@ -277,7 +276,6 @@ feed_eq_init(struct pcm_feeder *f) info->treble.gain = FEEDEQ_L2GAIN(50); info->bass.gain = FEEDEQ_L2GAIN(50); info->preamp = FEEDEQ_PREAMP2IDX(FEEDEQ_PREAMP_DEFAULT); - info->state = FEEDEQ_UNKNOWN; f->data = info; @@ -303,8 +301,6 @@ feed_eq_set(struct pcm_feeder *f, int what, int value) if (feeder_eq_validrate(value) == 0) return (EINVAL); info->rate = (uint32_t)value; - if (info->state == FEEDEQ_UNKNOWN) - info->state = FEEDEQ_ENABLE; return (feed_eq_setup(info)); case FEEDEQ_TREBLE: case FEEDEQ_BASS: @@ -320,12 +316,6 @@ feed_eq_set(struct pcm_feeder *f, int what, int value) return (EINVAL); info->preamp = FEEDEQ_PREAMP2IDX(value); break; - case FEEDEQ_STATE: - if (value != FEEDEQ_ENABLE) - return (EINVAL); - info->state = value; - feed_eq_reset(info); - break; default: return (EINVAL); } @@ -449,8 +439,6 @@ static int sysctl_dev_pcm_eq(SYSCTL_HANDLER_ARGS) { struct snddev_info *d; - struct pcm_channel *c; - struct pcm_feeder *f; int err, val, oval; d = oidp->oid_arg1; @@ -477,20 +465,11 @@ sysctl_dev_pcm_eq(SYSCTL_HANDLER_ARGS) PCM_LOCK(d); - if (val == 1) { - val = FEEDEQ_ENABLE; + if (val == 1) d->flags |= SD_F_EQ_ENABLED; - } else + else d->flags &= ~SD_F_EQ_ENABLED; - CHN_FOREACH(c, d, channels.pcm.busy) { - CHN_LOCK(c); - f = feeder_find(c, FEEDER_EQ); - if (f != NULL) - (void)FEEDER_SET(f, FEEDEQ_STATE, val); - CHN_UNLOCK(c); - } - PCM_RELEASE(d); PCM_UNLOCK(d); } else