From owner-freebsd-ports-bugs@freebsd.org Sun Apr 23 13:37:33 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB7DAD4B171 for ; Sun, 23 Apr 2017 13:37:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AAEAA1D1A for ; Sun, 23 Apr 2017 13:37:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3NDbX76011136 for ; Sun, 23 Apr 2017 13:37:33 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218827] r438058 and r438901 cause trouble for PACKAGES settings with colons in them Date: Sun, 23 Apr 2017 13:37:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Apr 2017 13:37:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218827 Bug ID: 218827 Summary: r438058 and r438901 cause trouble for PACKAGES settings with colons in them Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: dim@FreeBSD.org CC: freebsd-ports-bugs@FreeBSD.org On a number of FreeBSD boxes where I build ports, I have always had the PACKAGES setting point to a shared NFS directory where the packages should = end up. For example, in /etc/make.conf on a amd64-freebsd12 box: PACKAGES?=3D/share/dim/dist/FreeBSD:12:amd64/latest On an i386-freebsd10 box: PACKAGES?=3D/share/dim/dist/FreeBSD:10:i386/latest and so on. I use the same version:arch convention as pkg, so I can easily specify a common url in pkg.conf files, e.g.: url: "file:///share/dim/dist/${ABI}/latest" However, since r438058 and its follow-up r438901, this no longer works, and every invocation of make inside the ports tree gives a number of warnings a= bout duplicate targets: $ make foo make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate sc= ript for target "/share/dim/dist/FreeBSD" ignored make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previo= us script for "/share/dim/dist/FreeBSD" defined here make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate sc= ript for target "/share/dim/dist/FreeBSD" ignored make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previo= us script for "/share/dim/dist/FreeBSD" defined here make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate sc= ript for target "/share/dim/dist/FreeBSD" ignored make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previo= us script for "/share/dim/dist/FreeBSD" defined here make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate sc= ript for target "/share/dim/dist/FreeBSD" ignored make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previo= us script for "/share/dim/dist/FreeBSD" defined here make: don't know how to make foo. Stop This is because line 3292 of bsd.port.mk now specifies: ${PKGFILE}: ${WRKDIR_PKGFILE} ${PKGREPOSITORY} while before that, PKGFILE has been defined as: PKGREPOSITORY?=3D ${PACKAGES}/${PKGREPOSITORYSUBDIR} .if exists(${PACKAGES}) _HAVE_PACKAGES=3D yes PKGFILE?=3D ${PKGREPOSITORY}/${PKGNAME}${PKG_SUFX} E.g. the PACKAGES setting, complete with colons, ends up in PKGFILE. Afterwards, actually trying to build any port errors out with messages simi= lar to: $ make -C devel/gmake make: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate script for target "/share/dim/dist/FreeBSD" ignored make: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previous script for "/share/dim/dist/FreeBSD" defined here make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 5130: warning: duplicate sc= ript for target "/share/dim/dist/FreeBSD" ignored make[1]: "/share/dim/ports/Mk/bsd.port.mk" line 3294: warning: using previo= us script for "/share/dim/dist/FreeBSD" defined here =3D=3D=3D> License GPLv3 accepted by the user =3D=3D=3D> gmake-4.2.1_1 depends on file: /usr/local/sbin/pkg - found =3D=3D=3D> Fetching all distfiles required by gmake-4.2.1_1 for building =3D=3D=3D> Extracting for gmake-4.2.1_1 =3D> SHA256 Checksum OK for make-4.2.1.tar.bz2. make[1]: don't know how to make 12:amd64/latest/All:. Stop make[1]: stopped in /share/dim/ports/devel/gmake *** Error code 2 Stop. make: stopped in /share/dim/ports/devel/gmake I can confirm that reverting both r438058 and r438901 fixes this issue. --=20 You are receiving this mail because: You are on the CC list for the bug.=