From owner-cvs-all@FreeBSD.ORG Mon Jan 16 19:29:11 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 533D3106566C; Mon, 16 Jan 2012 19:29:11 +0000 (UTC) (envelope-from g.veniamin@googlemail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id C98EA8FC13; Mon, 16 Jan 2012 19:29:10 +0000 (UTC) Received: by ggki1 with SMTP id i1so3554022ggk.13 for ; Mon, 16 Jan 2012 11:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=+dVa1Ko0SY3HWqKkPXKmrmx8Dy0ejcoOcBR3jrlW9s8=; b=J7tdv9e8fjiYy/qbpQBR3qJSpKnnZUlk6FeX5/lpZ10vSVjdhseivWDyw7GvF/0GWY e3B77iWGc5+FsyALE23JVYzhAmwugx5Kej5vdfgUrcrjZvsw50OL19xBt21/1THPz3rk 4t9hhHB4GGO85NSqju97sKAOCnblIC8SaS6aY= MIME-Version: 1.0 Received: by 10.50.95.169 with SMTP id dl9mr14060699igb.12.1326740679402; Mon, 16 Jan 2012 11:04:39 -0800 (PST) Received: by 10.42.108.67 with HTTP; Mon, 16 Jan 2012 11:04:39 -0800 (PST) In-Reply-To: <4F1472E7.3010309@yandex.ru> References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> <201201161838.12941.makc@freebsd.org> <4F1472E7.3010309@yandex.ru> Date: Mon, 16 Jan 2012 22:04:39 +0300 Message-ID: From: Veniamin Gvozdikov To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Max Brazhnikov , Axel Gonzalez , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 19:29:11 -0000 I'm agree. 2012/1/16 Ruslan Mahmatkhanov : > Max Brazhnikov wrote on 16.01.2012 22:38: > >> On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote: >>> >>> rm =A0 =A0 =A0 =A0 =A02012-01-13 03:38:22 UTC >>> >>> =A0 FreeBSD ports repository >>> >>> =A0 Modified files: >>> =A0 =A0 audio/clementine-player Makefile >>> =A0 Added files: >>> =A0 =A0 audio/clementine-player/files patch-src-devices-cddadevice.h >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 pat= ch-src-devices-cddalister.cpp >>> =A0 Log: >>> =A0 - let it build with stock gcc >>> =A0 - optionify ipod and mtp support (default on) >> >> >> This type of `port optionification' leads to a nasty problem of hidden >> dependencies when options are unchecked, but corresponding libraries are >> presented. Please consider to commit the patch, which makes optional >> support >> really optional. >> >> Max > > > You are right, thank you. > Veniamin, do you have any objections if this patch will be committed? > > -- > Regards, > Ruslan > > Tinderboxing kills... the drives. --=20 Phone: +7 916 948 58 30 Site: http://zlonet.ru OpenGPG: g.veniamin(at)googlemail(dot)com | 9B9E5154 XMMP: zloidemon(at)jabber(dot)ru | 19B4A605