From nobody Mon Jun 13 21:18:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C7324837F41 for ; Mon, 13 Jun 2022 21:19:15 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMPZp5y6Dz4dNV for ; Mon, 13 Jun 2022 21:19:14 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-pg1-f176.google.com with SMTP id z14so2544361pgh.0 for ; Mon, 13 Jun 2022 14:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m2lMjQ5BDN+lKQ69CIHtZYEQntqgaauvSGqzPgyv9fw=; b=Qz9grIaDVmr/ndSn7nBzcOdHuAlkvVqKqCcf9ZLe21q4IUQsmjYutZ7ogo+5lPBuMH FwmvHDtA+FvxWjWwAJ480FjXpcVfR3ZZVl2sMiyg/Ed4HWlNooI/O1njimYvCqDEeeMc xUyIWWLBRt/XcIk2tdI5ki3Vs/z0gqteW/PpcSh2RW9kcMCpB/+WHZk+4RyzpHLbKfgb gRm8SUPwH2S0/NtXcz+2ci68sxuXOzwuL9T5RO/1AHeN7oVPo58CvdhwvtjWxdgOCRDI A9Y3eGRfngb5VOd7/okA8OeNwcKVCb31jwvM/hbtvvIgCdcGv5n6Q/pUmUQtNclimrZm YNKQ== X-Gm-Message-State: AOAM532d9FBQpzl5yTzp9uJr9INH/E5v+p7KsTYA1RKz2G8RdE2EMl85 d7QWQUpoYTjJMrydYDVB919zRQCyJwY= X-Google-Smtp-Source: ABdhPJye7Qm81tQfft7lLO/WIHkfntjdguXXyivjqGYZj1cf7QLOTlR1achBKEdAJiWbi7KgT3xNcw== X-Received: by 2002:a62:b802:0:b0:51b:f4d2:65be with SMTP id p2-20020a62b802000000b0051bf4d265bemr1248406pfe.79.1655155147342; Mon, 13 Jun 2022 14:19:07 -0700 (PDT) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com. [209.85.216.50]) by smtp.gmail.com with ESMTPSA id u10-20020a17090a410a00b001df4c5cab51sm5756479pjf.15.2022.06.13.14.19.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 14:19:06 -0700 (PDT) Received: by mail-pj1-f50.google.com with SMTP id e9so6741532pju.5 for ; Mon, 13 Jun 2022 14:19:06 -0700 (PDT) X-Received: by 2002:a17:903:234d:b0:167:4b11:aa7 with SMTP id c13-20020a170903234d00b001674b110aa7mr1039619plh.89.1655155145945; Mon, 13 Jun 2022 14:19:05 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Mon, 13 Jun 2022 14:18:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000085d1e305e15ad653" X-Rspamd-Queue-Id: 4LMPZp5y6Dz4dNV X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-1.91 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.09)[0.086]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.216.50:received,209.85.215.176:from]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; MLMMJ_DEST(0.00)[dev-commits-src-all]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.215.176:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-ThisMailContainsUnwantedMimeParts: N --00000000000085d1e305e15ad653 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 10, 2022 at 3:29 PM John Baldwin wrote: > On 5/23/22 4:54 PM, Eric Joyner wrote: > > The branch main has been updated by erj: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef > > > > commit cdcd52d41e246ba1c0fcfad0769bd691487355ef > > Author: Bartosz Sobczak > > AuthorDate: 2022-05-23 23:39:27 +0000 > > Commit: Eric Joyner > > CommitDate: 2022-05-23 23:52:49 +0000 > > > > irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 > > > > This is an initial commit for RDMA FreeBSD driver for Intel(R) > Ethernet > > Controller E810, called irdma. Supporting both RoCEv2 and iWARP > > protocols in per-PF manner, RoCEv2 being the default. > > > > Testing has been done using krping tool, perftest, ucmatose, rping, > > ud_pingpong, rc_pingpong and others. > > > > Signed-off-by: Eric Joyner > > > > Reviewed by: #manpages (pauamma_gundo.com) [documentation] > > MFC after: 1 week > > Relnotes: yes > > Sponsored by: Intel Corporation > > Differential Revision: https://reviews.freebsd.org/D34690 > > I'm trying to get the tree building again with GCC and ld.bfd does not like > libirdma.map at all complaining with an error: > > duplicate expression '*' in version information > > I looked at the version map, and it seems rather bogus to me and not like > version maps used anywhere else. It seems to be exporting all symbols in > two different versions? That would seem to defeat the point of having > symbol versions? > > /* Export symbols should be added below according to > Documentation/versioning.md document. */ > IRDMA_1.0 { > global: *; > local: *; > }; > > IRDMA_1.1 { > global: *; > } IRDMA_1.0; > > (I'm also not sure why lld accepts such a version map.) > > -- > John Baldwin > Hi, I don't know how to answer this; I'm going to forward this to the FreeBSD RDMA guy and another one (the first guy might still be out on vacation) and see if they can answer this. - Eric --00000000000085d1e305e15ad653 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jun 10, 2022 at 3:29 PM John Bald= win <jhb@freebsd.org> wrote:
On 5/23/22 4:54 PM, Eric Joyner wrote:
> The branch main has been updated by erj:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dcdcd52d41e246ba1c0fcfad0769bd691487355ef<= /a>
>
> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef
> Author:=C2=A0 =C2=A0 =C2=A0Bartosz Sobczak <bartosz.sobczak@intel.com> > AuthorDate: 2022-05-23 23:39:27 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Eric Joyner <erj@FreeBSD.org>
> CommitDate: 2022-05-23 23:52:49 +0000
>
>=C2=A0 =C2=A0 =C2=A0 irdma: Add RDMA driver for Intel(R) Ethernet Contr= oller E810
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 This is an initial commit for RDMA FreeBSD driver = for Intel(R) Ethernet
>=C2=A0 =C2=A0 =C2=A0 Controller E810, called irdma.=C2=A0 Supporting bo= th RoCEv2 and iWARP
>=C2=A0 =C2=A0 =C2=A0 protocols in per-PF manner, RoCEv2 being the defau= lt.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Testing has been done using krping tool, perftest,= ucmatose, rping,
>=C2=A0 =C2=A0 =C2=A0 ud_pingpong, rc_pingpong and others.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Signed-off-by: Eric Joyner <erj@FreeBSD.org>=
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 #manpages (pauamma_gundo.= com) [documentation]
>=C2=A0 =C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
>=C2=A0 =C2=A0 =C2=A0 Relnotes:=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0Intel Corporation
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D34690

I'm trying to get the tree building again with GCC and ld.bfd does not = like
libirdma.map at all complaining with an error:

duplicate expression '*' in version information

I looked at the version map, and it seems rather bogus to me and not like version maps used anywhere else.=C2=A0 It seems to be exporting all symbols= in
two different versions?=C2=A0 That would seem to defeat the point of having=
symbol versions?

/* Export symbols should be added below according to
=C2=A0 =C2=A0 Documentation/versioning.md document. */
IRDMA_1.0 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 local: *;
};

IRDMA_1.1 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;
} IRDMA_1.0;

(I'm also not sure why lld accepts such a version map.)

--
John Baldwin

Hi,

I don't know how to answer this; I'm going to forward this to th= e FreeBSD RDMA guy and another one (the first guy might still be out on vac= ation) and see if they can answer this.

- Eric
--00000000000085d1e305e15ad653--