From nobody Wed Sep 17 12:19:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cRd9Y1X9cz67Hl7; Wed, 17 Sep 2025 12:19:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cRd9X6sC3z3W3s; Wed, 17 Sep 2025 12:19:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFbND0ROnMWoODz6bd8YdVPma3aJ3Ia2L06mWr0wwt0=; b=pLp7XQnZfhgIFQ+YgyqUoVnFBS/5xs+RMjSoV/6dV8ubgzvvtVCyxKpRIGE62ET+lqQPdO OmhW/MUqTddMyb/VPZ5Kp3uO+qND5YCMm1AjJDbdd3mPrFD6jO6RUu6YHtkMQ0HvloBYOy 7IxUQMvWKcjXsaqkyCx47iAfxCCNxBy0+QbEHNQR+B6482PB+AaSXN2CvIgfhHQo+8Ws2U 2w7IDQn2CK/HU1TrxHPjHEM7quRFeM7o9qZn9FpIHBZ+NN+/CjoGo0JjS+geQUBUVgIaDY BnoKkttpg3y2LDwMVB8qJ2c0hPZ6uJnckYnC1wMwi44+b5ZrIRMDI+GwdA5sRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFbND0ROnMWoODz6bd8YdVPma3aJ3Ia2L06mWr0wwt0=; b=EZdskRPxxA7iRVQ46oS+tFppg+AVAqwK1ytVz9CQ8+uzxOT+2f0GZTvCI+ILgVaVl5eZx7 mpO2hwILN+RZs5fIW2gQIjudHa0+5MTW+j9yT92EoiZAm7jW46N9ZJkTiLtu/vSOrzg77c 1qV+Jn058QgoJcmA6YuCeEZshwBoxtHxhuQ5IslYDLLH1qFbz1t+YMVGdc7NaIKDJxY+72 1cMGDIap0j8oZvA71T1F5w97DFzE/ckTohZkD8+1BleDnq/jePwPtx2cF7cPdiVCeyjhCH l4GcHXzv3umCyXUIcnYCsUGvQcZXQhpLWPouuQLqBqx3MtUgzmqZaburTlardg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758111553; a=rsa-sha256; cv=none; b=Zn2qqe0WM/ndCTFB+EJGrE0LDw+ZixXEXmNO+cYJZDxptVUfNyczAQFNYEhLixQ2gXtWT1 dFbV/lx7HJ4xdV1HTMGxhBYkc4M8L/xckBNO5rs8kufwlr+aCDVbWrATL9YLW9gpbhsZte 6kfEArP902spTs+7oYmoHo8cHbq2uW2/OkxxV03RUyNm9avnQN1SXLQ/NttJF8tiwSp7Bf SBZpKdJ8eGybVxC3BvoTWoSPqpCKaZAi8htAXSSSBMbPYX2IfHwsYQqM6uH2vtyPf07ZFX /krVDAoM65XcKmxA+sUqLMxhsa37AW8Xx052hnevQp0tva6FBFTS2d/tV8vqwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cRd9X5tF3z9jy; Wed, 17 Sep 2025 12:19:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58HCJCrg085989; Wed, 17 Sep 2025 12:19:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58HCJCsr085986; Wed, 17 Sep 2025 12:19:12 GMT (envelope-from git) Date: Wed, 17 Sep 2025 12:19:12 GMT Message-Id: <202509171219.58HCJCsr085986@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 59049f4b47ea - main - hastd: Remove some now useless assertion List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 59049f4b47ea8924ffae7c3c7b9e8c00a79285e0 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=59049f4b47ea8924ffae7c3c7b9e8c00a79285e0 commit 59049f4b47ea8924ffae7c3c7b9e8c00a79285e0 Author: Olivier Certner AuthorDate: 2025-08-29 08:21:38 +0000 Commit: Olivier Certner CommitDate: 2025-09-17 12:16:05 +0000 hastd: Remove some now useless assertion It is in fact redundant with the previous one, as the set of supplementary groups is expected to be empty. MFC after: 5 days MFC to: stable/15 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52281 --- sbin/hastd/subr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sbin/hastd/subr.c b/sbin/hastd/subr.c index add1280e960b..084ea50dae7c 100644 --- a/sbin/hastd/subr.c +++ b/sbin/hastd/subr.c @@ -156,7 +156,6 @@ drop_privs(const struct hast_resource *res) struct passwd *pw; uid_t ruid, euid, suid; gid_t rgid, egid, sgid; - gid_t gidset[1]; bool capsicum, jailed; /* @@ -285,7 +284,6 @@ drop_privs(const struct hast_resource *res) PJDLOG_VERIFY(egid == pw->pw_gid); PJDLOG_VERIFY(sgid == pw->pw_gid); PJDLOG_VERIFY(getgroups(0, NULL) == 0); - PJDLOG_VERIFY(getgroups(1, gidset) == 0); pjdlog_debug(1, "Privileges successfully dropped using %s%s+setgid+setuid.",