From owner-cvs-src@FreeBSD.ORG Fri Jun 3 20:12:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8282C16A41C; Fri, 3 Jun 2005 20:12:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61A9A43D1D; Fri, 3 Jun 2005 20:12:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j53KCCqF077880; Fri, 3 Jun 2005 20:12:12 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j53KCC5k077879; Fri, 3 Jun 2005 20:12:12 GMT (envelope-from imp) Message-Id: <200506032012.j53KCC5k077879@repoman.freebsd.org> From: Warner Losh Date: Fri, 3 Jun 2005 20:12:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2005 20:12:12 -0000 imp 2005-06-03 20:12:12 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi.c Log: In newbus land, ivars can only be accessed for direct child, or when the driver has unholy private knowledge of its great-*cgrandchildren. The ACPI allocation routine lacked such knowledge when it tried to do a default allocation for all descendants, rather than just its immeidate children, so would access grandchild's ivar in an unsafe way. This could lead to a panic when devices were present which had no addresses setup by the BIOS, but which were later allocated in a lazy manner via pci_alloc_map. As such, only do the default allocation adjustments for immediate children. The manner that acpi_sysres_find accesses the resource list, used later in acpi_alloc_resource, is safe and proper so no additional test is needed there. This fixes a panic when probing an disabled ata controller on some newer intel blades. Reported by: dwhite Revision Changes Path 1.214 +1 -1 src/sys/dev/acpica/acpi.c