From nobody Wed Aug 13 11:33:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c25pd5yzrz64gFb; Wed, 13 Aug 2025 11:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c25pd2gGpz49nP; Wed, 13 Aug 2025 11:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755084793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZeSI/MWitKQGMlziejEabQT14dorgm+6/d9G7vC8hlY=; b=YWfB2eNA/L60Spaxju/6h/EKw1USlrJYd0YiU0DNWXIwn2dYfKR9jsi9+pyN0H4SskZJjz hoBsbDOUFUFKIuIdAf/h8Eb2bZDGJc4GnCk9nCLwVHPDbKCGTJiiAMiYsxt0rd5qoRybCV uRinfM7XSb/najc0elUgieWaoq9CTUO9NZUczR8CPZs8V1NMGcXWuGAHTux2XR5/hEKilX At98D9BuAh5qoj9074J2UmTwNhifE7rZjVq2FSsRqkGv6/5Ziob3jSUXctoAGjPGRZQt3V zqX57g5JXfaSiEFjxRor8hoNtj1XGgNeT/oPvVRqh0F4ZKl3sUmxipsIJAgh7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755084793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZeSI/MWitKQGMlziejEabQT14dorgm+6/d9G7vC8hlY=; b=PvDm0bFOt0pkxH+A0WkRjEtVYot1NAW5O02E/mDP7qeusxPk2ayUZvgRpO0yjeddOStE2X vVIkFTEaOUqrHzpY8AeK+igtbIeyl9MUJi4vHzcJgPTEAhC5BQ/tfVCfN0fv9UJ7MAyZaE AaBofHPQLDdwmtBw+Ey5Bn2/YdOwoud1I2BmG01yzi5Pa108xLJVVp0sR8tavhMdEGXf2W +7+ZljPtRTPsFP2GARX93qETLr64hwG/y1/L/4lO21TA+1fKGppbed7oZIUr56VCsCEiNn XkcQmCX+JKkxAkUhJ0/NTUK0jeitKU1KrT+JTetcNovLbXNM7uOxZI9w/NO/RQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755084793; a=rsa-sha256; cv=none; b=VgfU9JwM7ac+gL79io/hi1271eX+fl9KifV5OModQTDEUGVrlcX4dC7NYXlnGhFBYP3s2e Y5Std7KKt+d3rXnKh0LVYfNmOcqYxlvg7M5ITYu5PZSmEay60qFjv3Om3F3hepXv5aoNsX Nnq+iRgl6H8lOnVdx7P3iwOMrfBLfTkJjMNKYquXy8wm7rliJRkaP0LYjjr1om4j+WeyEQ +PMxplpcFZN7arzkY+oNiP+/qSuOtZD8ozrZAJmuHL05FppC+2uO0+Pbi6VuuJ2sDRz2xB 3i2Nmd2iMRYmK4TOvqcbStcPU+JF8WahJ8HfSqRnDyLK7nghuXCsdiHDeM4HAQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c25pd1zVLz1K5S; Wed, 13 Aug 2025 11:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57DBXDVd057239; Wed, 13 Aug 2025 11:33:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57DBXD2D057236; Wed, 13 Aug 2025 11:33:13 GMT (envelope-from git) Date: Wed, 13 Aug 2025 11:33:13 GMT Message-Id: <202508131133.57DBXD2D057236@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 28bac28d9074 - main - gpio: Fix incorrect dev being passed to gpiobus_detach_bus List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 28bac28d90740b2bd48e532ad7500d2f46210413 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=28bac28d90740b2bd48e532ad7500d2f46210413 commit 28bac28d90740b2bd48e532ad7500d2f46210413 Author: Evgenii Ivanov AuthorDate: 2025-08-12 04:17:13 +0000 Commit: Ahmad Khalifa CommitDate: 2025-08-13 11:15:46 +0000 gpio: Fix incorrect dev being passed to gpiobus_detach_bus Passing in the busdev will not detach from the bus correctly leaving the /dev/gpiocN entry Reviewed by: vexeduxr, imp Differential Revision: https://reviews.freebsd.org/D51857 --- sys/dev/iicbus/gpio/pcf8574.c | 4 +--- sys/dev/iicbus/gpio/tca64xx.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/iicbus/gpio/pcf8574.c b/sys/dev/iicbus/gpio/pcf8574.c index 86c78ffb15e6..bf60dec67557 100644 --- a/sys/dev/iicbus/gpio/pcf8574.c +++ b/sys/dev/iicbus/gpio/pcf8574.c @@ -159,9 +159,7 @@ pcf8574_detach(device_t dev) sc = device_get_softc(dev); - if (sc->busdev != NULL) - gpiobus_detach_bus(sc->busdev); - + gpiobus_detach_bus(dev); sx_destroy(&sc->lock); return (0); } diff --git a/sys/dev/iicbus/gpio/tca64xx.c b/sys/dev/iicbus/gpio/tca64xx.c index a973ef22f3fa..ab8fedd3f8fd 100644 --- a/sys/dev/iicbus/gpio/tca64xx.c +++ b/sys/dev/iicbus/gpio/tca64xx.c @@ -292,9 +292,7 @@ tca64xx_detach(device_t dev) sc = device_get_softc(dev); - if (sc->busdev != NULL) - gpiobus_detach_bus(sc->busdev); - + gpiobus_detach_bus(dev); mtx_destroy(&sc->mtx); return (0);