Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jun 2014 09:47:50 +0200
From:      Thomas Zander <riggs@freebsd.org>
To:        Daichi GOTO <daichi@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r359806 - head/devel/c-unit
Message-ID:  <CAFU734yiQCLLTWFtunDzsqe4ZToJPTCwTXsh3JFax66bT6yptA@mail.gmail.com>
In-Reply-To: <201406300708.s5U78dfE018117@svn.freebsd.org>
References:  <201406300708.s5U78dfE018117@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 30 June 2014 09:08, Daichi GOTO <daichi@freebsd.org> wrote:
> Author: daichi
> Date: Mon Jun 30 07:08:39 2014
> New Revision: 359806
> URL: http://svnweb.freebsd.org/changeset/ports/359806
> QAT: https://qat.redports.org/buildarchive/r359806/

Did you notice that the PR was already taken and has problems with the
examples? Because it clearly says so in the audit trail.
Now someone (maintainer? you? there is no record of it.) decided to
change the port to not include the examples by default.
But if built with the EXA option, this is the result:

====> Running Q/A tests (stage-qa)
Warning: 'lib/libcunit.so.1.0.1' is not stripped consider using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/examples/CUnit/Automated/AutomatedTest
Error: Orphaned: share/examples/CUnit/Automated/README
Error: Orphaned: share/examples/CUnit/Basic/BasicTest
Error: Orphaned: share/examples/CUnit/Basic/README
Error: Orphaned: share/examples/CUnit/Console/ConsoleTest
Error: Orphaned: share/examples/CUnit/Console/README
Error: Orphaned: @dirrmtry share/examples/CUnit/Automated
Error: Orphaned: @dirrmtry share/examples/CUnit/Basic
Error: Orphaned: @dirrmtry share/examples/CUnit/Console
Error: Orphaned: @dirrmtry share/examples/CUnit
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Stop.
make: stopped in /usr/ports/devel/c-unit

Please, if you snatch PRs from someone, fix them properly before committing.
Thanks
Riggs



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734yiQCLLTWFtunDzsqe4ZToJPTCwTXsh3JFax66bT6yptA>