From owner-freebsd-current Fri Jun 7 21:48:43 2002 Delivered-To: freebsd-current@freebsd.org Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by hub.freebsd.org (Postfix) with ESMTP id D559937B406; Fri, 7 Jun 2002 21:48:35 -0700 (PDT) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.12.3/8.12.3) with ESMTP id g584mZQ9068979; Fri, 7 Jun 2002 21:48:35 -0700 (PDT) (envelope-from kargl@troutmask.apl.washington.edu) Received: (from kargl@localhost) by troutmask.apl.washington.edu (8.12.3/8.12.3/Submit) id g584mZvv068978; Fri, 7 Jun 2002 21:48:35 -0700 (PDT) From: "Steven G. Kargl" Message-Id: <200206080448.g584mZvv068978@troutmask.apl.washington.edu> Subject: Re: patches for [x]install In-Reply-To: <20020607214350.A25230@FreeBSD.ORG> "from J. Mallett at Jun 7, 2002 09:43:50 pm" To: "J. Mallett" Date: Fri, 7 Jun 2002 21:48:35 -0700 (PDT) Cc: freebsd-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG J. Mallett said: > * From "Steven G. Kargl" > > The first patch fixes install(1). The reamining patches > > correctly document the breakage of rev 1.55 of xinstall.c I should have stated that if the first patch isn't acceptable, then the remaining patches should be applied. > > The last patch is wrong, the others are good, though a warning about the > overriding of flags might be nice until this is ACCEPTED behaviour by the > user community. > > The third patch is wrong because there are things other than -C that one > might want to override INSTALL with, for example an INSTALL that uses a > replacement program that static relinks an executable being installed > to a partition where its dynamic dependencies are not satisfied. No. The third patch is correct (see below); otherwise I could set INSTALL to " install -C" QED. > > I've known people to do similar. > > > --- share/mk/sys.mk.orig Fri Jun 7 18:05:26 2002 > > +++ share/mk/sys.mk Fri Jun 7 18:06:13 2002 > > @@ -67,7 +67,7 @@ > > .endif > > EFLAGS ?= > > > > -INSTALL ?= install > > +INSTALL = install > > > > LEX ?= lex > > LFLAGS ?= > > -- Steve http://troutmask.apl.washington.edu/~kargl/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message