From owner-svn-src-head@freebsd.org Wed Sep 13 22:42:34 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D48BFE13750; Wed, 13 Sep 2017 22:42:34 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 190167DF96; Wed, 13 Sep 2017 22:42:34 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v8DMWWOJ015130 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 13 Sep 2017 15:32:32 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v8DMWVTs015129; Wed, 13 Sep 2017 15:32:31 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 13 Sep 2017 15:32:31 -0700 From: Gleb Smirnoff To: Mateusz Guzik Cc: Bruce Evans , Mateusz Guzik , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r323393 - in head/sys: sys vm Message-ID: <20170913223231.GN1055@FreeBSD.org> References: <201709101900.v8AJ0c2N059845@repo.freebsd.org> <20170911111127.B870@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 22:42:34 -0000 On Mon, Sep 11, 2017 at 09:30:10AM +0200, Mateusz Guzik wrote: M> First, there is a bunch of counter(9) fields. I don't know the original M> reasoning. I would expect these counters to be statically defined in a M> per-cpu struct. The reasoning was to remove 'struct vmmeter' from the 'struct pcpu', which sounds inline with your desire to remote struct vmmeter from the kernel at all. Maintainance wise, it is much easier not to bloat 'struct pcpu' with various global statistics, but keep them as counter(9)s instead. Indeed, what's the big difference between TCP statistics and VM statistics, why treat them differently? Performance wise, I haven't seen any regressions when collapsed multiple entities of struct vmmeter sitting in struct pcpu, into single one with counter(9)s. -- Gleb Smirnoff