From owner-svn-src-head@FreeBSD.ORG  Sun Dec 16 22:59:26 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 3061D6C7;
 Sun, 16 Dec 2012 22:59:26 +0000 (UTC) (envelope-from pjd@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 1498A8FC1D;
 Sun, 16 Dec 2012 22:59:26 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qBGMxPKe067324;
 Sun, 16 Dec 2012 22:59:25 GMT (envelope-from pjd@svn.freebsd.org)
Received: (from pjd@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id qBGMxPRK067323;
 Sun, 16 Dec 2012 22:59:25 GMT (envelope-from pjd@svn.freebsd.org)
Message-Id: <201212162259.qBGMxPRK067323@svn.freebsd.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Sun, 16 Dec 2012 22:59:25 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r244316 - head/sbin/savecore
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Dec 2012 22:59:26 -0000

Author: pjd
Date: Sun Dec 16 22:59:25 2012
New Revision: 244316
URL: http://svnweb.freebsd.org/changeset/base/244316

Log:
  Prefer snprintf() over sprintf().
  
  Obtained from:	WHEEL Systems

Modified:
  head/sbin/savecore/savecore.c

Modified: head/sbin/savecore/savecore.c
==============================================================================
--- head/sbin/savecore/savecore.c	Sun Dec 16 22:06:28 2012	(r244315)
+++ head/sbin/savecore/savecore.c	Sun Dec 16 22:59:25 2012	(r244316)
@@ -543,7 +543,7 @@ DoFile(const char *savedir, const char *
 
 	writebounds(bounds + 1);
 
-	sprintf(buf, "info.%d", bounds);
+	snprintf(buf, sizeof(buf), "info.%d", bounds);
 
 	/*
 	 * Create or overwrite any existing dump header files.
@@ -556,12 +556,12 @@ DoFile(const char *savedir, const char *
 	}
 	oumask = umask(S_IRWXG|S_IRWXO); /* Restrict access to the core file.*/
 	if (compress) {
-		sprintf(filename, "%s.%d.gz", istextdump ? "textdump.tar" :
-		    "vmcore", bounds);
+		snprintf(filename, sizeof(filename), "%s.%d.gz",
+		    istextdump ? "textdump.tar" : "vmcore", bounds);
 		fp = zopen(filename, "w");
 	} else {
-		sprintf(filename, "%s.%d", istextdump ? "textdump.tar" :
-		    "vmcore", bounds);
+		snprintf(filename, sizeof(filename), "%s.%d",
+		    istextdump ? "textdump.tar" : "vmcore", bounds);
 		fp = fopen(filename, "w");
 	}
 	if (fp == NULL) {